[Cluster-devel] [PATCH] gfs2/inode.c: local functions should be static

[Cluster-devel] [PATCH] gfs2/inode.c: local functions should be static

[Steven Whitehouse]

Hi,

On Fri, 2011-09-23 at 15:51 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
> 
Where did you find this function? It is not in the upstream gfs2 code...

Steve.

> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> 
> ---
> 
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 5431de9..5f2b157 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -624,7 +624,7 @@ fail:
>  	return error;
>  }
>  
> -int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
>  		    void *fs_info)
>  {
>  	const struct xattr *xattr;

[Cluster-devel] [PATCH] gfs2/inode.c: local functions should be static

[Steven Whitehouse]

Hi,

On Mon, 2011-09-26 at 11:54 -0500, H Hartley Sweeten wrote:
> On Monday, September 26, 2011 1:28 AM, Steven Whitehouse wrote:
> > Hi,
> >
> > On Fri, 2011-09-23 at 15:51 -0700, H Hartley Sweeten wrote:
> >> Quiets the sparse noise:
> >> 
> >> warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
> >> 
> > Where did you find this function? It is not in the upstream gfs2 code...
> 
> linux-next next-20110831
> 
> This was the last update I pulled before git.kernel.org went down.
> 
> It looks like it was added by:
> 
> commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
> Author: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Date:   Mon Jun 6 15:29:25 2011 -0400
> 
>     security: new security_inode_init_security API adds function callback
> 
> If this has been removed since then please ignore.
> 
> Thanks,
> Hartley

I think it is a question of it not yet being added. You should send the
patch to Mimi so it is included in the correct patch series. Otherwise
remind me when the code is applies against is merged and I'll look at it
again then,

Steve.