From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Wed, 18 Jan 2012 16:39:29 +0000 Subject: [Cluster-devel] [PATCH 3/5] fsck.gfs2: Plug a leak in find_block_ref() In-Reply-To: <1326904771-12416-1-git-send-email-anprice@redhat.com> References: <1326904771-12416-1-git-send-email-anprice@redhat.com> Message-ID: <1326904771-12416-3-git-send-email-anprice@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Spotted by coverity: Variable "ip" going out of scope leaks the storage it points to. Signed-off-by: Andrew Price --- gfs2/fsck/pass1b.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gfs2/fsck/pass1b.c b/gfs2/fsck/pass1b.c index ae6d45c..9e6f376 100644 --- a/gfs2/fsck/pass1b.c +++ b/gfs2/fsck/pass1b.c @@ -344,6 +344,7 @@ static int find_block_ref(struct gfs2_sbd *sdp, uint64_t inode) log_debug( _("Block %lld (0x%llx) is not gfs2 metadata.\n"), (unsigned long long)inode, (unsigned long long)inode); + fsck_inode_put(&ip); return 1; } /* Check to see if this inode was referenced by another by mistake */ -- 1.7.7.5