From mboxrd@z Thu Jan 1 00:00:00 1970 From: rpeterso@redhat.com Date: Fri, 20 Jan 2012 09:09:53 -0600 Subject: [Cluster-devel] [PATCH 12/66] fsck.gfs2: get rid of triple negative logic In-Reply-To: <1327072247-26275-1-git-send-email-rpeterso@redhat.com> References: <1327072247-26275-1-git-send-email-rpeterso@redhat.com> Message-ID: <1327072247-26275-13-git-send-email-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Bob Peterson This patch changes the logic of the code from being triple-negative to single-negative so it won't twist your brain into knots. rhbz#675723 --- gfs2/fsck/metawalk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c index 2db389f..888acec 100644 --- a/gfs2/fsck/metawalk.c +++ b/gfs2/fsck/metawalk.c @@ -930,7 +930,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block, uint8_t q; struct duptree *d; - if (!valid_block(ip->i_sbd, block) != 0) + if (!valid_block(ip->i_sbd, block)) return -EFAULT; q = block_type(block); -- 1.7.7.5