From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/2] libgfs2: Clean up some warnings
Date: Mon, 30 Apr 2012 18:29:48 +0100 [thread overview]
Message-ID: <1335806988-24872-2-git-send-email-anprice@redhat.com> (raw)
In-Reply-To: <1335806988-24872-1-git-send-email-anprice@redhat.com>
Fixes these warnings:
fs_geometry.c:80:47: warning: variable 'rlast2' set but not used
[-Wunused-but-set-variable]
meta.c:732:3: warning: large integer implicitly truncated to unsigned
type [-Woverflow]
Signed-off-by: Andrew Price <anprice@redhat.com>
---
gfs2/libgfs2/fs_geometry.c | 3 +--
gfs2/libgfs2/meta.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/gfs2/libgfs2/fs_geometry.c b/gfs2/libgfs2/fs_geometry.c
index fb55697..e248f7c 100644
--- a/gfs2/libgfs2/fs_geometry.c
+++ b/gfs2/libgfs2/fs_geometry.c
@@ -77,7 +77,7 @@ void compute_rgrp_layout(struct gfs2_sbd *sdp, struct osi_root *rgtree,
int rgsize_specified)
{
struct device *dev;
- struct rgrp_tree *rl, *rlast = NULL, *rlast2 = NULL;
+ struct rgrp_tree *rl, *rlast = NULL;
struct osi_node *n, *next = NULL;
unsigned int rgrp = 0, nrgrp, rglength;
uint64_t rgaddr;
@@ -105,7 +105,6 @@ void compute_rgrp_layout(struct gfs2_sbd *sdp, struct osi_root *rgtree,
PRIx64 "), length = %"PRIu64" (0x%"
PRIx64 ")\n", rgrp + 1, rl->start, rl->start,
rl->length, rl->length);
- rlast2 = rlast;
rlast = rl;
}
rlast->start = rlast->ri.ri_addr;
diff --git a/gfs2/libgfs2/meta.c b/gfs2/libgfs2/meta.c
index 87f8f31..1f796c8 100644
--- a/gfs2/libgfs2/meta.c
+++ b/gfs2/libgfs2/meta.c
@@ -729,7 +729,7 @@ const struct lgfs2_metadata lgfs2_metadata[] = {
},
[LGFS2_MT_FREE] = {
.gfs1 = 1,
- .gfs2 = 2,
+ .gfs2 = 1,
.name = "free",
},
};
--
1.7.7.6
next prev parent reply other threads:[~2012-04-30 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 17:29 [Cluster-devel] [PATCH 1/2] libgfs2: Remove gfs_get_leaf_nr Andrew Price
2012-04-30 17:29 ` Andrew Price [this message]
2012-05-01 9:23 ` [Cluster-devel] [PATCH 2/2] libgfs2: Clean up some warnings Steven Whitehouse
2012-05-01 9:22 ` [Cluster-devel] [PATCH 1/2] libgfs2: Remove gfs_get_leaf_nr Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335806988-24872-2-git-send-email-anprice@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).