From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Wed, 16 May 2012 13:28:13 +0100 Subject: [Cluster-devel] [GFS2 Patch] GFS2: Fix quota adjustment return code In-Reply-To: <40d26de0-0d10-4c0e-94c0-78d827ed7f02@zmail12.collab.prod.int.phx2.redhat.com> References: <40d26de0-0d10-4c0e-94c0-78d827ed7f02@zmail12.collab.prod.int.phx2.redhat.com> Message-ID: <1337171293.2696.58.camel@menhir> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On Tue, 2012-05-15 at 14:51 -0400, Bob Peterson wrote: > Hi, > > This patch changes function gfs2_adjust_quota so that it properly > returns a good (zero) return code on the normal path through the code. > Without this, mounting GFS2 with -o quota=account periodically gave > this error message: GFS2: fsid=cluster:fs: gfs2_quotad: sync error -5 > Now in the -nmw git tree. Thanks, Steve. > Regards, > > Bob Peterson > Red Hat File Systems > > Signed-off-by: Bob Peterson > --- > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c > index 02df0de..197cc2d 100644 > --- a/fs/gfs2/quota.c > +++ b/fs/gfs2/quota.c > @@ -744,7 +744,7 @@ get_a_page: > i_size_write(inode, size); > inode->i_mtime = inode->i_atime = CURRENT_TIME; > mark_inode_dirty(inode); > - return err; > + return 0; > > unlock_out: > unlock_page(page); >