* [Cluster-devel] [GFS2 Patch] GFS2: Fix quota adjustment return code [not found] <244fe9c3-81db-4202-a506-aa77c2e5225a@zmail12.collab.prod.int.phx2.redhat.com> @ 2012-05-15 18:51 ` Bob Peterson 2012-05-16 12:28 ` Steven Whitehouse 0 siblings, 1 reply; 2+ messages in thread From: Bob Peterson @ 2012-05-15 18:51 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, This patch changes function gfs2_adjust_quota so that it properly returns a good (zero) return code on the normal path through the code. Without this, mounting GFS2 with -o quota=account periodically gave this error message: GFS2: fsid=cluster:fs: gfs2_quotad: sync error -5 Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson <rpeterso@redhat.com> --- diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 02df0de..197cc2d 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -744,7 +744,7 @@ get_a_page: i_size_write(inode, size); inode->i_mtime = inode->i_atime = CURRENT_TIME; mark_inode_dirty(inode); - return err; + return 0; unlock_out: unlock_page(page); ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 Patch] GFS2: Fix quota adjustment return code 2012-05-15 18:51 ` [Cluster-devel] [GFS2 Patch] GFS2: Fix quota adjustment return code Bob Peterson @ 2012-05-16 12:28 ` Steven Whitehouse 0 siblings, 0 replies; 2+ messages in thread From: Steven Whitehouse @ 2012-05-16 12:28 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, On Tue, 2012-05-15 at 14:51 -0400, Bob Peterson wrote: > Hi, > > This patch changes function gfs2_adjust_quota so that it properly > returns a good (zero) return code on the normal path through the code. > Without this, mounting GFS2 with -o quota=account periodically gave > this error message: GFS2: fsid=cluster:fs: gfs2_quotad: sync error -5 > Now in the -nmw git tree. Thanks, Steve. > Regards, > > Bob Peterson > Red Hat File Systems > > Signed-off-by: Bob Peterson <rpeterso@redhat.com> > --- > diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c > index 02df0de..197cc2d 100644 > --- a/fs/gfs2/quota.c > +++ b/fs/gfs2/quota.c > @@ -744,7 +744,7 @@ get_a_page: > i_size_write(inode, size); > inode->i_mtime = inode->i_atime = CURRENT_TIME; > mark_inode_dirty(inode); > - return err; > + return 0; > > unlock_out: > unlock_page(page); > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-16 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <244fe9c3-81db-4202-a506-aa77c2e5225a@zmail12.collab.prod.int.phx2.redhat.com>
2012-05-15 18:51 ` [Cluster-devel] [GFS2 Patch] GFS2: Fix quota adjustment return code Bob Peterson
2012-05-16 12:28 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).