From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Gruenbacher <andreas.gruenbacher@linbit.com>
Date: Thu, 12 Dec 2013 20:07:54 +0100 (CET)
Subject: [Cluster-devel] [PATCH 04/18] fs: add generic xattr_acl handlers
In-Reply-To: <20131211104527.044064384@bombadil.infradead.org>
References: <20131211104243.148113893@bombadil.infradead.org>
	<20131211104527.044064384@bombadil.infradead.org>
Message-ID: <1342716144.69126.1386875274180.JavaMail.zimbra@linbit.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Christoph,

> +static int
> +posix_acl_xattr_set(struct dentry *dentry, const char *name,
> +		const void *value, size_t size, int flags, int type)
> +{
> +	struct inode *inode = dentry->d_inode;
> +	struct posix_acl *acl = NULL;
> +	int ret;
> +
> +	if (!IS_POSIXACL(inode))
> +		return -EOPNOTSUPP;
> +	if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> +		return -EOPNOTSUPP;

Sama here, I would remove the S_ISLNK() check.

Andreas