From mboxrd@z Thu Jan 1 00:00:00 1970 From: rpeterso@redhat.com Date: Thu, 9 Aug 2012 12:48:47 -0500 Subject: [Cluster-devel] [PATCH 6/6] GFS2: Eliminate unnecessary check for state > 3 in bitfit In-Reply-To: <1344534527-28721-1-git-send-email-rpeterso@redhat.com> References: <1344534527-28721-1-git-send-email-rpeterso@redhat.com> Message-ID: <1344534527-28721-7-git-send-email-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Bob Peterson Function gfs2_bitfit was checking for state > 3, but that's impossible since it is only called from rgblk_search, which receives only GFS2_BLKST_ constants. --- fs/gfs2/rgrp.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index c267118..47d2346 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -228,8 +228,6 @@ static u32 gfs2_bitfit(const u8 *buf, const unsigned int len, u64 mask = 0x5555555555555555ULL; u32 bit; - BUG_ON(state > 3); - /* Mask off bits we don't care about at the start of the search */ mask <<= spoint; tmp = gfs2_bit_search(ptr, mask, state); -- 1.7.7.6