cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: add error check while allocating new inodes
Date: Fri, 16 Nov 2012 15:16:03 +0000	[thread overview]
Message-ID: <1353078963.2731.54.camel@menhir> (raw)
In-Reply-To: <581283624.41715543.1353075099812.JavaMail.root@redhat.com>

Hi,

On Fri, 2012-11-16 at 09:11 -0500, Bob Peterson wrote:
> Hi,
> 
> This patch adds a return code check after attempting to allocate
> a new inode during dinode creation.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems
> 
Both patches in the -nmw tree now. Thanks,

Steve.

> Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
> ---
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index e321333..2405695 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -674,6 +674,10 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
>  		goto fail_gunlock;
>  
>  	inode = new_inode(sdp->sd_vfs);
> +	if (!inode) {
> +		gfs2_glock_dq_uninit(ghs);
> +		return -ENOMEM;
> +	}
>  	ip = GFS2_I(inode);
>  	error = gfs2_rs_alloc(ip);
>  	if (error)




      reply	other threads:[~2012-11-16 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 14:11 [Cluster-devel] [GFS2 PATCH] GFS2: add error check while allocating new inodes Bob Peterson
2012-11-16 15:16 ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353078963.2731.54.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).