From: Marek 'marx' Grac <mgrac@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/7] COMPATIBILITY BREAK: fence_rsb replace -n / telnet_port with standard --ipport / ipport
Date: Sun, 25 Nov 2012 14:18:07 +0100 [thread overview]
Message-ID: <1353849490-15635-4-git-send-email-mgrac@redhat.com> (raw)
In-Reply-To: <1353849490-15635-1-git-send-email-mgrac@redhat.com>
telnet_port has same functionality as ipport and -n is usually used for port number/UUID
---
fence/agents/rsb/fence_rsb.py | 15 +++------------
1 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/fence/agents/rsb/fence_rsb.py b/fence/agents/rsb/fence_rsb.py
index a701156..61066ee 100755
--- a/fence/agents/rsb/fence_rsb.py
+++ b/fence/agents/rsb/fence_rsb.py
@@ -37,27 +37,18 @@ def set_power_status(conn, options):
conn.log_expect(options, options["--command-prompt"], int(options["--shell-timeout"]))
def main():
- device_opt = [ "ipaddr", "ipport", "telnet_port", "login", "passwd", "secure", "cmd_prompt" ]
+ device_opt = [ "ipaddr", "ipport", "login", "passwd", "secure", "cmd_prompt" ]
atexit.register(atexit_handler)
- all_opt["telnet_port"] = {
- "getopt" : "n:",
- "longopt" : "telnet_port",
- "help" : "-n TCP port to use (deprecated, use -u)",
- "required" : "0",
- "shortdesc" : "TCP port to use for connection with device (default is 3172 for telnet)",
- "order" : 1
- }
+
all_opt["cmd_prompt"]["default"] = "to quit:"
opt = process_input(device_opt)
- # option -n for backward compatibility (-n is normally port no)
- if 1 == opt.has_key("--telnet_port"):
- opt["--port"] = opt["--telnet_port"]
# set default port for telnet only
if 0 == opt.has_key("--ssh") and 0 == opt.has_key("--ipport"):
opt["--ipport"] = "3172"
+
options = check_input(device_opt, opt)
docs = { }
--
1.7.7.6
next prev parent reply other threads:[~2012-11-25 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 13:18 [Cluster-devel] [PATCH 1/7] COMPATIBILITY BREAK: remove option -T / --test / test Marek 'marx' Grac
2012-11-25 13:18 ` [Cluster-devel] [PATCH 2/7] COMPATIBILITY BREAK: fence_drac5 replace --m / --modulename / modulename / module_name with standard -n / --plug / port Marek 'marx' Grac
2012-11-25 13:18 ` [Cluster-devel] [PATCH 3/7] COMPATIBILITY BREAK: fence_lpar replace --n / --partition / partition " Marek 'marx' Grac
2012-11-25 13:18 ` Marek 'marx' Grac [this message]
2012-11-25 13:18 ` [Cluster-devel] [PATCH 5/7] COMPATIBILITY BREAK: Remove obsolete options from STDIN Marek 'marx' Grac
2012-11-25 13:18 ` [Cluster-devel] [PATCH 6/7] COMPATIBILITY BREAK: replace udpport with ipport, make ipport dependent on ipaddress Marek 'marx' Grac
2012-11-25 13:18 ` [Cluster-devel] [PATCH 7/7] COMPATIBILITY BREAK: remove -q / quiet Marek 'marx' Grac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353849490-15635-4-git-send-email-mgrac@redhat.com \
--to=mgrac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).