cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [TRIVIAL PATCH 19/26] gfs2: Convert print_symbol to %pSR
Date: Thu, 13 Dec 2012 10:57:31 +0000	[thread overview]
Message-ID: <1355396251.2708.8.camel@menhir> (raw)
In-Reply-To: <9e86924627c3e2fa6e45bd07537115a291db50fe.1355335228.git.joe@perches.com>

Hi,

Acked-by: Steven Whitehouse <swhiteho@redhat.com>

Steve.

On Wed, 2012-12-12 at 10:19 -0800, Joe Perches wrote:
> Use the new vsprintf extension to avoid any possible
> message interleaving.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  fs/gfs2/glock.c |    4 ++--
>  fs/gfs2/trans.c |    3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 992c5c0..453978b 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -1016,11 +1016,11 @@ do_cancel:
>  	return;
>  
>  trap_recursive:
> -	print_symbol(KERN_ERR "original: %s\n", gh2->gh_ip);
> +	printk(KERN_ERR "original: %pSR\n", (void *)gh2->gh_ip);
>  	printk(KERN_ERR "pid: %d\n", pid_nr(gh2->gh_owner_pid));
>  	printk(KERN_ERR "lock type: %d req lock state : %d\n",
>  	       gh2->gh_gl->gl_name.ln_type, gh2->gh_state);
> -	print_symbol(KERN_ERR "new: %s\n", gh->gh_ip);
> +	printk(KERN_ERR "new: %pSR\n", (void *)gh->gh_ip);
>  	printk(KERN_ERR "pid: %d\n", pid_nr(gh->gh_owner_pid));
>  	printk(KERN_ERR "lock type: %d req lock state : %d\n",
>  	       gh->gh_gl->gl_name.ln_type, gh->gh_state);
> diff --git a/fs/gfs2/trans.c b/fs/gfs2/trans.c
> index 4136270..3d8aa7f 100644
> --- a/fs/gfs2/trans.c
> +++ b/fs/gfs2/trans.c
> @@ -95,7 +95,8 @@ static void gfs2_log_release(struct gfs2_sbd *sdp, unsigned int blks)
>  
>  static void gfs2_print_trans(const struct gfs2_trans *tr)
>  {
> -	print_symbol(KERN_WARNING "GFS2: Transaction created at: %s\n", tr->tr_ip);
> +	printk(KERN_WARNING "GFS2: Transaction created at: %pSR\n",
> +	       (void *)tr->tr_ip);
>  	printk(KERN_WARNING "GFS2: blocks=%u revokes=%u reserved=%u touched=%d\n",
>  	       tr->tr_blocks, tr->tr_revokes, tr->tr_reserved, tr->tr_touched);
>  	printk(KERN_WARNING "GFS2: Buf %u/%u Databuf %u/%u Revoke %u/%u\n",




  reply	other threads:[~2012-12-13 10:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12 18:18 [Cluster-devel] [TRIVIAL PATCH 00/26] treewide: Add and use vsprintf extension %pSR Joe Perches
2012-12-12 18:19 ` [Cluster-devel] [TRIVIAL PATCH 19/26] gfs2: Convert print_symbol to %pSR Joe Perches
2012-12-13 10:57   ` Steven Whitehouse [this message]
2013-04-29 13:23     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355396251.2708.8.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).