cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] GFS2: Initialize hex string to '0'
Date: Thu, 13 Dec 2012 10:59:57 +0000	[thread overview]
Message-ID: <1355396397.2708.10.camel@menhir> (raw)
In-Reply-To: <20121211220124.GR1396@redhat.com>

Hi,

Thanks for the patch - I'll put it in the tree just as soon as Linus as
pulled the current set of patches,

Steve.

On Tue, 2012-12-11 at 17:01 -0500, Nathan Straz wrote:
> When generating the DLM lock name, a value of 0 would skip
> the loop and leave the string unchanged.  This left locks with
> a value of 0 unlabeled.  Initializing the string to '0' fixes this.
> ---
>  fs/gfs2/lock_dlm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
> index 0fb6539..a924b6a 100644
> --- a/fs/gfs2/lock_dlm.c
> +++ b/fs/gfs2/lock_dlm.c
> @@ -239,6 +239,7 @@ static u32 make_flags(struct gfs2_glock *gl, const unsigned int gfs_flags,
>  
>  static void gfs2_reverse_hex(char *c, u64 value)
>  {
> +	*c = '0';
>  	while (value) {
>  		*c-- = hex_asc[value & 0x0f];
>  		value >>= 4;




      reply	other threads:[~2012-12-13 10:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 22:01 [Cluster-devel] [PATCH] GFS2: Initialize hex string to '0' Nathan Straz
2012-12-13 10:59 ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355396397.2708.10.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).