From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/4] GFS2: Initialize hex string to '0'
Date: Thu, 3 Jan 2013 11:50:07 +0000 [thread overview]
Message-ID: <1357213810-3739-2-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1357213810-3739-1-git-send-email-swhiteho@redhat.com>
From: Nathan Straz <nstraz@redhat.com>
When generating the DLM lock name, a value of 0 would skip
the loop and leave the string unchanged. This left locks with
a value of 0 unlabeled. Initializing the string to '0' fixes this.
Signed-off-by: Nathan Straz <nstraz@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
index 8dad6b0..b906ed1 100644
--- a/fs/gfs2/lock_dlm.c
+++ b/fs/gfs2/lock_dlm.c
@@ -241,6 +241,7 @@ static u32 make_flags(struct gfs2_glock *gl, const unsigned int gfs_flags,
static void gfs2_reverse_hex(char *c, u64 value)
{
+ *c = '0';
while (value) {
*c-- = hex_asc[value & 0x0f];
value >>= 4;
--
1.7.4
next prev parent reply other threads:[~2013-01-03 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 11:50 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2013-01-03 11:50 ` Steven Whitehouse [this message]
2013-01-03 11:50 ` [Cluster-devel] [PATCH 2/4] GFS2: Fix race in gfs2_rs_alloc Steven Whitehouse
2013-01-03 11:50 ` [Cluster-devel] [PATCH 3/4] GFS2: Stop looking for free blocks at end of rgrp Steven Whitehouse
2013-01-03 11:50 ` [Cluster-devel] [PATCH 4/4] GFS2: Reset rd_last_alloc when it reaches the end of the rgrp Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357213810-3739-2-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).