cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Get a block reservation before resizing a file
Date: Fri, 01 Feb 2013 21:13:28 +0000	[thread overview]
Message-ID: <1359753208.2714.80.camel@menhir> (raw)
In-Reply-To: <1847869626.18286471.1359738182937.JavaMail.root@redhat.com>

Hi,

Now in the -nmw tree. Thanks,

Steve.

On Fri, 2013-02-01 at 12:03 -0500, Bob Peterson wrote:
> Hi,
> 
> This patch allocates a block reservation structure before growing 
> or shrinking a file. Without this structure, the grow or shink code
> can reference the bad pointer.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems
> 
> Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
> ---
>  fs/gfs2/bmap.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
> index d29d779..df686d1 100644
> --- a/fs/gfs2/bmap.c
> +++ b/fs/gfs2/bmap.c
> @@ -1288,6 +1288,10 @@ int gfs2_setattr_size(struct inode *inode, u64 newsize)
>  
>  	inode_dio_wait(inode);
>  
> +	ret = gfs2_rs_alloc(GFS2_I(inode));
> +	if (ret)
> +		return ret;
> +
>  	oldsize = inode->i_size;
>  	if (newsize >= oldsize)
>  		return do_grow(inode, newsize);
> 




      reply	other threads:[~2013-02-01 21:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <60871952.18277548.1359737783438.JavaMail.root@redhat.com>
2013-02-01 17:03 ` [Cluster-devel] [GFS2 PATCH] GFS2: Get a block reservation before resizing a file Bob Peterson
2013-02-01 21:13   ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359753208.2714.80.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).