cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] GFS2: return error if malloc failed in gfs2_rs_alloc()
Date: Mon, 11 Mar 2013 16:09:23 +0000	[thread overview]
Message-ID: <1363018163.2698.25.camel@menhir> (raw)
In-Reply-To: <CAPgLHd9eg02c+HiLN9AGNDYUCx1qey7sSr6DoR6tJnp20eAvcw@mail.gmail.com>

Hi,

Now in the GFS2 -nmw tree. Thanks,

Steve.

On Mon, 2013-03-11 at 23:01 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> The error code in gfs2_rs_alloc() is set to ENOMEM when error
> but never be used, instead, gfs2_rs_alloc() always return 0.
> Fix to return 'error'.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  fs/gfs2/rgrp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index 9d16a6f..b850198 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
>  	RB_CLEAR_NODE(&ip->i_res->rs_node);
>  out:
>  	up_write(&ip->i_rw_mutex);
> -	return 0;
> +	return error;
>  }
>  
>  static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)
> 
> 




      reply	other threads:[~2013-03-11 16:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11 15:01 [Cluster-devel] [PATCH] GFS2: return error if malloc failed in gfs2_rs_alloc() Wei Yongjun
2013-03-11 16:09 ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363018163.2698.25.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).