From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/6] GFS2: return error if malloc failed in gfs2_rs_alloc()
Date: Fri, 5 Apr 2013 10:57:13 +0100 [thread overview]
Message-ID: <1365155836-3069-4-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1365155836-3069-1-git-send-email-swhiteho@redhat.com>
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The error code in gfs2_rs_alloc() is set to ENOMEM when error
but never be used, instead, gfs2_rs_alloc() always return 0.
Fix to return 'error'.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index d1f51fd..70d1cd0 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
RB_CLEAR_NODE(&ip->i_res->rs_node);
out:
up_write(&ip->i_rw_mutex);
- return 0;
+ return error;
}
static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)
--
1.7.4
next prev parent reply other threads:[~2013-04-05 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 9:57 [Cluster-devel] GFS2: Pre-pull patch posting Steven Whitehouse
2013-04-05 9:57 ` [Cluster-devel] [PATCH 1/6] GFS2: use kmalloc for lvb bitmap Steven Whitehouse
2013-04-05 9:57 ` [Cluster-devel] [PATCH 2/6] GFS2: use memchr_inv Steven Whitehouse
2013-04-05 9:57 ` Steven Whitehouse [this message]
2013-04-05 9:57 ` [Cluster-devel] [PATCH 4/6] GFS2: Fix unlock of fcntl locks during withdrawn state Steven Whitehouse
2013-04-05 9:57 ` [Cluster-devel] [PATCH 5/6] " Steven Whitehouse
2013-04-05 9:57 ` [Cluster-devel] [PATCH 6/6] GFS2: Issue discards in 512b sectors Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365155836-3069-4-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).