From mboxrd@z Thu Jan 1 00:00:00 1970 From: rpeterso@redhat.com Date: Mon, 8 Apr 2013 07:41:03 -0700 Subject: [Cluster-devel] [PATCH 31/42] fsck.gfs2: Log when unrecoverable data block errors are encountered In-Reply-To: <1365432074-17615-1-git-send-email-rpeterso@redhat.com> References: <1365432074-17615-1-git-send-email-rpeterso@redhat.com> Message-ID: <1365432074-17615-32-git-send-email-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Bob Peterson This patch adds a log message whenever unrecoverable data block errors are found. Otherwise the output doesn't say why it stopped processing data, and which block had the problem. rhbz#902920 --- gfs2/fsck/metawalk.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c index e1a685a..4e18a7b 100644 --- a/gfs2/fsck/metawalk.c +++ b/gfs2/fsck/metawalk.c @@ -1322,10 +1322,15 @@ static int check_data(struct gfs2_inode *ip, struct metawalk_fxns *pass, pass1. Therefore the individual check_data functions should do a range check. */ rc = pass->check_data(ip, metablock, block, pass->private); + if (!error && rc) { + error = rc; + log_info(_("\nUnrecoverable data block error %d on " + "block %llu (0x%llx).\n"), rc, + (unsigned long long)block, + (unsigned long long)block); + } if (rc < 0) return rc; - if (!error && rc) - error = rc; (*blks_checked)++; } return error; -- 1.7.11.7