From mboxrd@z Thu Jan 1 00:00:00 1970 From: rpeterso@redhat.com Date: Mon, 8 Apr 2013 07:41:11 -0700 Subject: [Cluster-devel] [PATCH 39/42] fsck.gfs2: When flagging a duplicate reference, show valid or invalid In-Reply-To: <1365432074-17615-1-git-send-email-rpeterso@redhat.com> References: <1365432074-17615-1-git-send-email-rpeterso@redhat.com> Message-ID: <1365432074-17615-40-git-send-email-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Bob Peterson This patch changes the logging when duplicate block references are flagged. The idea is to print whether or not the inode with the reference is valid or invalid, which helps in diagnosing problems when duplicate block references are resolved. rhbz#902920 --- gfs2/fsck/util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gfs2/fsck/util.c b/gfs2/fsck/util.c index fc3a0ec..ef59e6e 100644 --- a/gfs2/fsck/util.c +++ b/gfs2/fsck/util.c @@ -399,9 +399,10 @@ int add_duplicate_ref(struct gfs2_inode *ip, uint64_t block, id->reftypecount[reftype]++; id->dup_count++; log_info( _("Found %d reference(s) to block %llu" - " (0x%llx) as %s in inode #%llu (0x%llx)\n"), + " (0x%llx) as %s in %s inode #%llu (0x%llx)\n"), id->dup_count, (unsigned long long)block, (unsigned long long)block, reftypes[reftype], + inode_valid ? _("valid") : _("invalid"), (unsigned long long)ip->i_di.di_num.no_addr, (unsigned long long)ip->i_di.di_num.no_addr); if (first) -- 1.7.11.7