cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v1 04/11] locks: make "added" in __posix_lock_file a bool
Date: Fri, 31 May 2013 23:07:27 -0400	[thread overview]
Message-ID: <1370056054-25449-5-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1370056054-25449-1-git-send-email-jlayton@redhat.com>

...save 3 bytes of stack space.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/locks.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/locks.c b/fs/locks.c
index a7d2253..cef0e04 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -800,7 +800,8 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
 	struct file_lock *left = NULL;
 	struct file_lock *right = NULL;
 	struct file_lock **before;
-	int error, added = 0;
+	int error;
+	bool added = false;
 
 	/*
 	 * We may need two file_lock structures for this operation,
@@ -894,7 +895,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
 				continue;
 			}
 			request = fl;
-			added = 1;
+			added = true;
 		}
 		else {
 			/* Processing for different lock types is a bit
@@ -905,7 +906,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
 			if (fl->fl_start > request->fl_end)
 				break;
 			if (request->fl_type == F_UNLCK)
-				added = 1;
+				added = true;
 			if (fl->fl_start < request->fl_start)
 				left = fl;
 			/* If the next lock in the list has a higher end
@@ -935,7 +936,7 @@ static int __posix_lock_file(struct inode *inode, struct file_lock *request, str
 				locks_release_private(fl);
 				locks_copy_private(fl, request);
 				request = fl;
-				added = 1;
+				added = true;
 			}
 		}
 		/* Go on to next lock.
-- 
1.7.1



  parent reply	other threads:[~2013-06-01  3:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  3:07 [Cluster-devel] [PATCH v1 00/11] locks: scalability improvements for file locking Jeff Layton
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 01/11] cifs: use posix_unblock_lock instead of locks_delete_block Jeff Layton
2013-06-03 21:53   ` J. Bruce Fields
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 02/11] locks: make generic_add_lease and generic_delete_lease static Jeff Layton
2013-06-03 21:53   ` J. Bruce Fields
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 03/11] locks: comment cleanups and clarifications Jeff Layton
2013-06-03 22:00   ` J. Bruce Fields
2013-06-04 11:09     ` Jeff Layton
2013-06-01  3:07 ` Jeff Layton [this message]
2013-06-04 20:17   ` [Cluster-devel] [PATCH v1 04/11] locks: make "added" in __posix_lock_file a bool J. Bruce Fields
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 05/11] locks: encapsulate the fl_link list handling Jeff Layton
2013-06-04 20:17   ` J. Bruce Fields
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 06/11] locks: convert to i_lock to protect i_flock list Jeff Layton
2013-06-04 21:22   ` J. Bruce Fields
2013-06-05  0:46     ` Jeff Layton
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 07/11] locks: only pull entries off of blocked_list when they are really unblocked Jeff Layton
2013-06-04 21:58   ` J. Bruce Fields
2013-06-05 11:38     ` Jeff Layton
2013-06-05 12:24       ` J. Bruce Fields
2013-06-05 12:38         ` Jeff Layton
2013-06-05 12:59           ` J. Bruce Fields
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 08/11] locks: convert fl_link to a hlist_node Jeff Layton
2013-06-04 21:59   ` J. Bruce Fields
2013-06-05 11:43     ` Jeff Layton
2013-06-05 12:46       ` J. Bruce Fields
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 09/11] locks: turn the blocked_list into a hashtable Jeff Layton
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 10/11] locks: add a new "lm_owner_key" lock operation Jeff Layton
2013-06-01  3:07 ` [Cluster-devel] [PATCH v1 11/11] locks: give the blocked_hash its own spinlock Jeff Layton
2013-06-04 14:19   ` Stefan Metzmacher
2013-06-04 14:39     ` Jeff Layton
2013-06-04 14:46     ` Christoph Hellwig
2013-06-04 14:53       ` J. Bruce Fields
2013-06-04 15:15         ` Jeff Layton
2013-06-04 14:56       ` Jeff Layton
2013-06-03 19:04 ` [Cluster-devel] [PATCH v1 00/11] locks: scalability improvements for file locking Davidlohr Bueso
2013-06-03 21:31 ` J. Bruce Fields
2013-06-04 10:54   ` Jeff Layton
2013-06-04 11:56     ` Jim Rees
2013-06-04 12:15       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370056054-25449-5-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).