From: michaelc@cs.wisc.edu <michaelc@cs.wisc.edu>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/6] dlm: clear correct bit during sctp init failure handling
Date: Fri, 14 Jun 2013 04:56:11 -0500 [thread overview]
Message-ID: <1371203774-13141-4-git-send-email-michaelc@cs.wisc.edu> (raw)
In-Reply-To: <1371203774-13141-1-git-send-email-michaelc@cs.wisc.edu>
From: Mike Christie <michaelc@cs.wisc.edu>
We should be testing and cleaing the init pending bit because later
when sctp_init_assoc is recalled it will be checking that it is not set
and set the bit.
We do not want to touch CF_CONNECT_PENDING here because we will queue
swork and process_send_sockets will then call the connect_action function.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
fs/dlm/lowcomms.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 1536599..87e68dd 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -562,7 +562,7 @@ static void sctp_send_shutdown(sctp_assoc_t associd)
static void sctp_init_failed_foreach(struct connection *con)
{
con->sctp_assoc = 0;
- if (test_and_clear_bit(CF_CONNECT_PENDING, &con->flags)) {
+ if (test_and_clear_bit(CF_INIT_PENDING, &con->flags)) {
if (!test_and_set_bit(CF_WRITE_PENDING, &con->flags))
queue_work(send_workqueue, &con->swork);
}
--
1.7.1
next prev parent reply other threads:[~2013-06-14 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:56 [Cluster-devel] [PATCH 0/6] dlm: sctp use fixes michaelc
2013-06-14 9:56 ` [Cluster-devel] [PATCH 1/6] dlm: clear correct init bit during sctp setup michaelc
2013-06-14 9:56 ` [Cluster-devel] [PATCH 2/6] dlm: set sctp assoc id during setup michaelc
2013-06-14 9:56 ` michaelc [this message]
2013-06-14 9:56 ` [Cluster-devel] [PATCH 4/6] dlm: try other IPs when sctp init assoc fails michaelc
2013-06-14 9:56 ` [Cluster-devel] [PATCH 5/6] dlm: retry failed SCTP sends michaelc
2013-06-14 9:56 ` [Cluster-devel] [PATCH 6/6] dlm: disable nagle for SCTP michaelc
2013-06-14 18:12 ` [Cluster-devel] [PATCH 0/6] dlm: sctp use fixes David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371203774-13141-4-git-send-email-michaelc@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).