From mboxrd@z Thu Jan 1 00:00:00 1970 From: michaelc@cs.wisc.edu Date: Fri, 14 Jun 2013 04:56:11 -0500 Subject: [Cluster-devel] [PATCH 3/6] dlm: clear correct bit during sctp init failure handling In-Reply-To: <1371203774-13141-1-git-send-email-michaelc@cs.wisc.edu> References: <1371203774-13141-1-git-send-email-michaelc@cs.wisc.edu> Message-ID: <1371203774-13141-4-git-send-email-michaelc@cs.wisc.edu> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Mike Christie We should be testing and cleaing the init pending bit because later when sctp_init_assoc is recalled it will be checking that it is not set and set the bit. We do not want to touch CF_CONNECT_PENDING here because we will queue swork and process_send_sockets will then call the connect_action function. Signed-off-by: Mike Christie --- fs/dlm/lowcomms.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 1536599..87e68dd 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -562,7 +562,7 @@ static void sctp_send_shutdown(sctp_assoc_t associd) static void sctp_init_failed_foreach(struct connection *con) { con->sctp_assoc = 0; - if (test_and_clear_bit(CF_CONNECT_PENDING, &con->flags)) { + if (test_and_clear_bit(CF_INIT_PENDING, &con->flags)) { if (!test_and_set_bit(CF_WRITE_PENDING, &con->flags)) queue_work(send_workqueue, &con->swork); } -- 1.7.1