cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: michaelc@cs.wisc.edu <michaelc@cs.wisc.edu>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 6/6] dlm: disable nagle for SCTP
Date: Fri, 14 Jun 2013 04:56:14 -0500	[thread overview]
Message-ID: <1371203774-13141-7-git-send-email-michaelc@cs.wisc.edu> (raw)
In-Reply-To: <1371203774-13141-1-git-send-email-michaelc@cs.wisc.edu>

From: Mike Christie <michaelc@cs.wisc.edu>

For TCP we disable Nagle and I cannot think of why it would be needed
for SCTP. When disabled it seems to improve dlm_lock operations like it
does for TCP.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
 fs/dlm/lowcomms.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index a4fad32..4f539dd 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1346,6 +1346,7 @@ static int sctp_listen_for_all(void)
 	int result = -EINVAL, num = 1, i, addr_len;
 	struct connection *con = nodeid2con(0, GFP_NOFS);
 	int bufsize = NEEDED_RMEM;
+	int one = 1;
 
 	if (!con)
 		return -ENOMEM;
@@ -1380,6 +1381,11 @@ static int sctp_listen_for_all(void)
 		goto create_delsock;
 	}
 
+	result = kernel_setsockopt(sock, SOL_SCTP, SCTP_NODELAY, (char *)&one,
+				   sizeof(one));
+	if (result < 0)
+		log_print("Could not set SCTP NODELAY error %d\n", result);
+
 	/* Init con struct */
 	sock->sk->sk_user_data = con;
 	con->sock = sock;
-- 
1.7.1



  parent reply	other threads:[~2013-06-14  9:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14  9:56 [Cluster-devel] [PATCH 0/6] dlm: sctp use fixes michaelc
2013-06-14  9:56 ` [Cluster-devel] [PATCH 1/6] dlm: clear correct init bit during sctp setup michaelc
2013-06-14  9:56 ` [Cluster-devel] [PATCH 2/6] dlm: set sctp assoc id during setup michaelc
2013-06-14  9:56 ` [Cluster-devel] [PATCH 3/6] dlm: clear correct bit during sctp init failure handling michaelc
2013-06-14  9:56 ` [Cluster-devel] [PATCH 4/6] dlm: try other IPs when sctp init assoc fails michaelc
2013-06-14  9:56 ` [Cluster-devel] [PATCH 5/6] dlm: retry failed SCTP sends michaelc
2013-06-14  9:56 ` michaelc [this message]
2013-06-14 18:12 ` [Cluster-devel] [PATCH 0/6] dlm: sctp use fixes David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371203774-13141-7-git-send-email-michaelc@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).