* [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c [not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com> @ 2014-02-09 12:49 ` Rashika Kheria 2014-02-09 13:04 ` Josh Triplett 2014-02-09 13:10 ` [Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria 1 sibling, 1 reply; 4+ messages in thread From: Rashika Kheria @ 2014-02-09 12:49 UTC (permalink / raw) To: cluster-devel.redhat.com Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it contains function prototypes of some functions defined in fs/dlm/ast.c. This also eliminates the following warning in fs/dlm/ast: fs/dlm/ast.c:52:5: warning: no previous prototype for ?dlm_add_lkb_callback? [-Wmissing-prototypes] fs/dlm/ast.c:113:5: warning: no previous prototype for ?dlm_rem_lkb_callback? [-Wmissing-prototypes] fs/dlm/ast.c:174:6: warning: no previous prototype for ?dlm_add_cb? [-Wmissing-prototypes] fs/dlm/ast.c:212:6: warning: no previous prototype for ?dlm_callback_work? [-Wmissing-prototypes] fs/dlm/ast.c:267:5: warning: no previous prototype for ?dlm_callback_start? [-Wmissing-prototypes] fs/dlm/ast.c:278:6: warning: no previous prototype for ?dlm_callback_stop? [-Wmissing-prototypes] fs/dlm/ast.c:284:6: warning: no previous prototype for ?dlm_callback_suspend? [-Wmissing-prototypes] fs/dlm/ast.c:292:6: warning: no previous prototype for ?dlm_callback_resume? [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> --- fs/dlm/ast.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c index 0e90f0c..42794c0 100644 --- a/fs/dlm/ast.c +++ b/fs/dlm/ast.c @@ -14,6 +14,7 @@ #include "dlm_internal.h" #include "lock.h" #include "user.h" +#include "ast.h" static uint64_t dlm_cb_seq; static DEFINE_SPINLOCK(dlm_cb_seq_spin); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c 2014-02-09 12:49 ` [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria @ 2014-02-09 13:04 ` Josh Triplett 0 siblings, 0 replies; 4+ messages in thread From: Josh Triplett @ 2014-02-09 13:04 UTC (permalink / raw) To: cluster-devel.redhat.com On Sun, Feb 09, 2014 at 06:19:17PM +0530, Rashika Kheria wrote: > Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it > contains function prototypes of some functions defined in fs/dlm/ast.c. > > This also eliminates the following warning in fs/dlm/ast: > fs/dlm/ast.c:52:5: warning: no previous prototype for ?dlm_add_lkb_callback? [-Wmissing-prototypes] > fs/dlm/ast.c:113:5: warning: no previous prototype for ?dlm_rem_lkb_callback? [-Wmissing-prototypes] > fs/dlm/ast.c:174:6: warning: no previous prototype for ?dlm_add_cb? [-Wmissing-prototypes] > fs/dlm/ast.c:212:6: warning: no previous prototype for ?dlm_callback_work? [-Wmissing-prototypes] > fs/dlm/ast.c:267:5: warning: no previous prototype for ?dlm_callback_start? [-Wmissing-prototypes] > fs/dlm/ast.c:278:6: warning: no previous prototype for ?dlm_callback_stop? [-Wmissing-prototypes] > fs/dlm/ast.c:284:6: warning: no previous prototype for ?dlm_callback_suspend? [-Wmissing-prototypes] > fs/dlm/ast.c:292:6: warning: no previous prototype for ?dlm_callback_resume? [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> > fs/dlm/ast.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c > index 0e90f0c..42794c0 100644 > --- a/fs/dlm/ast.c > +++ b/fs/dlm/ast.c > @@ -14,6 +14,7 @@ > #include "dlm_internal.h" > #include "lock.h" > #include "user.h" > +#include "ast.h" > > static uint64_t dlm_cb_seq; > static DEFINE_SPINLOCK(dlm_cb_seq_spin); > -- > 1.7.9.5 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c [not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com> 2014-02-09 12:49 ` [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria @ 2014-02-09 13:10 ` Rashika Kheria 2014-02-10 12:30 ` Steven Whitehouse 1 sibling, 1 reply; 4+ messages in thread From: Rashika Kheria @ 2014-02-09 13:10 UTC (permalink / raw) To: cluster-devel.redhat.com Mark functions as static in gfs2/rgrp.c because they are not used outside this file. This eliminates the following warning in gfs2/rgrp.c: fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ?gfs2_rgrp_bh_get? [-Wmissing-prototypes] fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ?update_rgrp_lvb? [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> --- fs/gfs2/rgrp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index a1da213..551b9e9 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd) * Returns: errno */ -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd) +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd) { struct gfs2_sbd *sdp = rgd->rd_sbd; struct gfs2_glock *gl = rgd->rd_gl; @@ -1169,7 +1169,7 @@ fail: return error; } -int update_rgrp_lvb(struct gfs2_rgrpd *rgd) +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd) { u32 rl_flags; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c 2014-02-09 13:10 ` [Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria @ 2014-02-10 12:30 ` Steven Whitehouse 0 siblings, 0 replies; 4+ messages in thread From: Steven Whitehouse @ 2014-02-10 12:30 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, On Sun, 2014-02-09 at 18:40 +0530, Rashika Kheria wrote: > Mark functions as static in gfs2/rgrp.c because they are not used > outside this file. > > This eliminates the following warning in gfs2/rgrp.c: > fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ?gfs2_rgrp_bh_get? [-Wmissing-prototypes] > fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ?update_rgrp_lvb? [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> > Reviewed-by: Josh Triplett <josh@joshtriplett.org> > --- > fs/gfs2/rgrp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Now in the GFS2 -nmw tree. Thanks, Steve. > diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c > index a1da213..551b9e9 100644 > --- a/fs/gfs2/rgrp.c > +++ b/fs/gfs2/rgrp.c > @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd) > * Returns: errno > */ > > -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd) > +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd) > { > struct gfs2_sbd *sdp = rgd->rd_sbd; > struct gfs2_glock *gl = rgd->rd_gl; > @@ -1169,7 +1169,7 @@ fail: > return error; > } > > -int update_rgrp_lvb(struct gfs2_rgrpd *rgd) > +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd) > { > u32 rl_flags; > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-10 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
2014-02-09 12:49 ` [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria
2014-02-09 13:04 ` Josh Triplett
2014-02-09 13:10 ` [Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria
2014-02-10 12:30 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).