cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] [GFS2 PATCH] GFS2: Remove extraneous function gfs2_security_init
       [not found] <49650852.2014435.1395236099773.JavaMail.zimbra@redhat.com>
@ 2014-03-19 13:37 ` Bob Peterson
  2014-03-19 15:21   ` Steven Whitehouse
  0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2014-03-19 13:37 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hi,

This patch eliminates function gfs2_security_init in favor of just
calling security_inode_init_security directly.

Regards,

Bob Peterson
Red Hat File Systems

Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
---
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index ec455b9..e790949 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -571,13 +571,6 @@ static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 	return err;
 }
 
-static int gfs2_security_init(struct gfs2_inode *dip, struct gfs2_inode *ip,
-			      const struct qstr *qstr)
-{
-	return security_inode_init_security(&ip->i_inode, &dip->i_inode, qstr,
-					    &gfs2_initxattrs, NULL);
-}
-
 /**
  * gfs2_create_inode - Create a new inode
  * @dir: The parent directory
@@ -758,7 +751,8 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
 	if (error)
 		goto fail_gunlock3;
 
-	error = gfs2_security_init(dip, ip, name);
+	error = security_inode_init_security(&ip->i_inode, &dip->i_inode, name,
+					     &gfs2_initxattrs, NULL);
 	if (error)
 		goto fail_gunlock3;
 



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Cluster-devel] [GFS2 PATCH] GFS2: Remove extraneous function gfs2_security_init
  2014-03-19 13:37 ` [Cluster-devel] [GFS2 PATCH] GFS2: Remove extraneous function gfs2_security_init Bob Peterson
@ 2014-03-19 15:21   ` Steven Whitehouse
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2014-03-19 15:21 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hi,

Both patches now in the -nmw tree. Thanks,

Steve.

On Wed, 2014-03-19 at 09:37 -0400, Bob Peterson wrote:
> Hi,
> 
> This patch eliminates function gfs2_security_init in favor of just
> calling security_inode_init_security directly.
> 
> Regards,
> 
> Bob Peterson
> Red Hat File Systems
> 
> Signed-off-by: Bob Peterson <rpeterso@redhat.com> 
> ---
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index ec455b9..e790949 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -571,13 +571,6 @@ static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
>  	return err;
>  }
>  
> -static int gfs2_security_init(struct gfs2_inode *dip, struct gfs2_inode *ip,
> -			      const struct qstr *qstr)
> -{
> -	return security_inode_init_security(&ip->i_inode, &dip->i_inode, qstr,
> -					    &gfs2_initxattrs, NULL);
> -}
> -
>  /**
>   * gfs2_create_inode - Create a new inode
>   * @dir: The parent directory
> @@ -758,7 +751,8 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
>  	if (error)
>  		goto fail_gunlock3;
>  
> -	error = gfs2_security_init(dip, ip, name);
> +	error = security_inode_init_security(&ip->i_inode, &dip->i_inode, name,
> +					     &gfs2_initxattrs, NULL);
>  	if (error)
>  		goto fail_gunlock3;
>  
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-19 15:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <49650852.2014435.1395236099773.JavaMail.zimbra@redhat.com>
2014-03-19 13:37 ` [Cluster-devel] [GFS2 PATCH] GFS2: Remove extraneous function gfs2_security_init Bob Peterson
2014-03-19 15:21   ` Steven Whitehouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).