* [Cluster-devel] [GFS2 PATCH] [TRY #2] GFS2: inline function gfs2_set_mode [not found] <1834202248.2101300.1395244186633.JavaMail.zimbra@redhat.com> @ 2014-03-19 15:51 ` Bob Peterson 2014-03-19 16:17 ` Steven Whitehouse 0 siblings, 1 reply; 2+ messages in thread From: Bob Peterson @ 2014-03-19 15:51 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, Here is a revised patch based on Steve's feedback: This patch eliminates function gfs2_set_mode which was only called in one place, and always returned 0. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson <rpeterso@redhat.com> --- diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c index 394dc55..3088e2a 100644 --- a/fs/gfs2/acl.c +++ b/fs/gfs2/acl.c @@ -64,18 +64,6 @@ struct posix_acl *gfs2_get_acl(struct inode *inode, int type) return acl; } -static int gfs2_set_mode(struct inode *inode, umode_t mode) -{ - int error = 0; - - if (mode != inode->i_mode) { - inode->i_mode = mode; - mark_inode_dirty(inode); - } - - return error; -} - int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type) { int error; @@ -98,9 +86,10 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type) if (error == 0) acl = NULL; - error = gfs2_set_mode(inode, mode); - if (error) - return error; + if (mode != inode->i_mode) { + inode->i_mode = mode; + mark_inode_dirty(inode); + } } if (acl) { ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 PATCH] [TRY #2] GFS2: inline function gfs2_set_mode 2014-03-19 15:51 ` [Cluster-devel] [GFS2 PATCH] [TRY #2] GFS2: inline function gfs2_set_mode Bob Peterson @ 2014-03-19 16:17 ` Steven Whitehouse 0 siblings, 0 replies; 2+ messages in thread From: Steven Whitehouse @ 2014-03-19 16:17 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, On Wed, 2014-03-19 at 11:51 -0400, Bob Peterson wrote: > Hi, > > Here is a revised patch based on Steve's feedback: > > This patch eliminates function gfs2_set_mode which was only called in > one place, and always returned 0. > Now in the -nmw tree. Thanks, Steve. > Regards, > > Bob Peterson > Red Hat File Systems > > Signed-off-by: Bob Peterson <rpeterso@redhat.com> > --- > diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c > index 394dc55..3088e2a 100644 > --- a/fs/gfs2/acl.c > +++ b/fs/gfs2/acl.c > @@ -64,18 +64,6 @@ struct posix_acl *gfs2_get_acl(struct inode *inode, int type) > return acl; > } > > -static int gfs2_set_mode(struct inode *inode, umode_t mode) > -{ > - int error = 0; > - > - if (mode != inode->i_mode) { > - inode->i_mode = mode; > - mark_inode_dirty(inode); > - } > - > - return error; > -} > - > int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type) > { > int error; > @@ -98,9 +86,10 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type) > if (error == 0) > acl = NULL; > > - error = gfs2_set_mode(inode, mode); > - if (error) > - return error; > + if (mode != inode->i_mode) { > + inode->i_mode = mode; > + mark_inode_dirty(inode); > + } > } > > if (acl) { > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-19 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1834202248.2101300.1395244186633.JavaMail.zimbra@redhat.com>
2014-03-19 15:51 ` [Cluster-devel] [GFS2 PATCH] [TRY #2] GFS2: inline function gfs2_set_mode Bob Peterson
2014-03-19 16:17 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).