* [Cluster-devel] [GFS2 PATCH] gfs2: Fix return value in slot_get()
@ 2014-03-31 6:19 Abhi Das
2014-03-31 9:47 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Abhi Das @ 2014-03-31 6:19 UTC (permalink / raw)
To: cluster-devel.redhat.com
ENOSPC was being returned in slot_get inspite of successful
execution of the function. This patch fixes this return
code.
Signed-off-by: Abhi Das <adas@redhat.com>
---
fs/gfs2/quota.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 27f9435..c4effff 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -332,6 +332,7 @@ static int slot_get(struct gfs2_quota_data *qd)
if (bit < sdp->sd_quota_slots) {
set_bit(bit, sdp->sd_quota_bitmap);
qd->qd_slot = bit;
+ error = 0;
out:
qd->qd_slot_count++;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [GFS2 PATCH] gfs2: Fix return value in slot_get()
2014-03-31 6:19 [Cluster-devel] [GFS2 PATCH] gfs2: Fix return value in slot_get() Abhi Das
@ 2014-03-31 9:47 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2014-03-31 9:47 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
On Mon, 2014-03-31 at 01:19 -0500, Abhi Das wrote:
> ENOSPC was being returned in slot_get inspite of successful
> execution of the function. This patch fixes this return
> code.
>
> Signed-off-by: Abhi Das <adas@redhat.com>
> ---
> fs/gfs2/quota.c | 1 +
> 1 file changed, 1 insertion(+)
>
Now in the -nmw git tree. Thanks,
Steve.
> diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
> index 27f9435..c4effff 100644
> --- a/fs/gfs2/quota.c
> +++ b/fs/gfs2/quota.c
> @@ -332,6 +332,7 @@ static int slot_get(struct gfs2_quota_data *qd)
> if (bit < sdp->sd_quota_slots) {
> set_bit(bit, sdp->sd_quota_bitmap);
> qd->qd_slot = bit;
> + error = 0;
> out:
> qd->qd_slot_count++;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-31 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 6:19 [Cluster-devel] [GFS2 PATCH] gfs2: Fix return value in slot_get() Abhi Das
2014-03-31 9:47 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).