cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/5] fsck.gfs2: Log to syslog on start and exit
Date: Wed,  7 May 2014 15:33:37 +0100	[thread overview]
Message-ID: <1399473221-28521-1-git-send-email-anprice@redhat.com> (raw)

In order to piece together the order in which fsck.gfs2 runs and
gfs2_edit savemeta were done it's useful to keep a log of the command
line options used and the fsck.gfs2 start and end times. Log these to
syslog.

Signed-off-by: Andrew Price <anprice@redhat.com>
---
 gfs2/fsck/main.c     | 35 +++++++++++++++++++++++++++++++++++
 gfs2/man/fsck.gfs2.8 |  2 ++
 2 files changed, 37 insertions(+)

diff --git a/gfs2/fsck/main.c b/gfs2/fsck/main.c
index 346e580..0031ec0 100644
--- a/gfs2/fsck/main.c
+++ b/gfs2/fsck/main.c
@@ -12,6 +12,7 @@
 #include <libintl.h>
 #include <locale.h>
 #define _(String) gettext(String)
+#include <syslog.h>
 
 #include "copyright.cf"
 #include "libgfs2.h"
@@ -261,6 +262,36 @@ static int fsck_pass(const struct fsck_pass *p, struct gfs2_sbd *sdp)
 	return 0;
 }
 
+static void exitlog(void)
+{
+	syslog(LOG_INFO, "exiting.");
+}
+
+static void startlog(int argc, char **argv)
+{
+	int i;
+	char *cmd, *p;
+	size_t len;
+
+	for (len = i = 0; i < argc; i++)
+		len += strlen(argv[i]);
+	len += argc; /* Add spaces and '\0' */
+
+	cmd = malloc(len);
+	if (cmd == NULL) {
+		perror(argv[0]);
+		exit(FSCK_ERROR);
+	}
+	p = cmd;
+	for (i = 0; i < argc; i++, p++) {
+		p = stpcpy(p, argv[i]);
+		*p = ' ';
+	}
+	*(--p) = '\0';
+	syslog(LOG_INFO, "started: %s", cmd);
+	free(cmd);
+}
+
 int main(int argc, char **argv)
 {
 	struct gfs2_sbd sb;
@@ -274,6 +305,10 @@ int main(int argc, char **argv)
 	setlocale(LC_ALL, "");
 	textdomain("gfs2-utils");
 
+	openlog("fsck.gfs2", LOG_CONS|LOG_PID, LOG_USER);
+	startlog(argc - 1, &argv[1]);
+	atexit(exitlog);
+
 	memset(sdp, 0, sizeof(*sdp));
 
 	if ((error = read_cmdline(argc, argv, &opts)))
diff --git a/gfs2/man/fsck.gfs2.8 b/gfs2/man/fsck.gfs2.8
index 3ecfbe3..56dcddc 100644
--- a/gfs2/man/fsck.gfs2.8
+++ b/gfs2/man/fsck.gfs2.8
@@ -35,6 +35,8 @@ computer.  Therefore, fsck.gfs2 will always check the file system unless
 the -p (preen) option is used, in which case it follows special rules
 (see below).
 
+fsck.gfs2 will log to the system log on start and exit to aid debugging and
+administration.
 .SH OPTIONS
 .TP
 \fB-a\fP
-- 
1.9.0



             reply	other threads:[~2014-05-07 14:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 14:33 Andrew Price [this message]
2014-05-07 14:33 ` [Cluster-devel] [PATCH 2/5] gfs2-utils: Expressly expunge 'expert mode' Andrew Price
2014-05-07 14:48   ` Bob Peterson
2014-05-07 15:01     ` Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 3/5] libgfs2: Remove UI fields from struct gfs2_sbd Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 4/5] libgfs2: Remove debug field from gfs2_sbd Andrew Price
2014-05-07 14:33 ` [Cluster-devel] [PATCH 5/5] libgfs2: Remove logging API Andrew Price
2014-05-07 14:48   ` Steven Whitehouse
2014-05-07 14:55   ` Bob Peterson
2014-05-07 15:07     ` Andrew Price
2014-05-07 15:17       ` Andrew Price
2014-05-07 14:39 ` [Cluster-devel] [PATCH 1/5] fsck.gfs2: Log to syslog on start and exit Steven Whitehouse
2014-05-07 15:15   ` Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399473221-28521-1-git-send-email-anprice@redhat.com \
    --to=anprice@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).