cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/6] GFS2: lops.c: replace 0 by NULL for pointers
Date: Tue,  3 Jun 2014 12:02:29 +0100	[thread overview]
Message-ID: <1401793353-1469-3-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1401793353-1469-1-git-send-email-swhiteho@redhat.com>

From: Fabian Frederick <fabf@skynet.be>

Sparse warning: fs/gfs2/lops.c:78:29:
"warning: Using plain integer as NULL pointer"

Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index a294d8d..2c1ae86 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -75,7 +75,7 @@ static void maybe_release_space(struct gfs2_bufdata *bd)
 	unsigned int index = bd->bd_bh->b_blocknr - gl->gl_name.ln_number;
 	struct gfs2_bitmap *bi = rgd->rd_bits + index;
 
-	if (bi->bi_clone == 0)
+	if (bi->bi_clone == NULL)
 		return;
 	if (sdp->sd_args.ar_discard)
 		gfs2_rgrp_send_discards(sdp, rgd->rd_data0, bd->bd_bh, bi, 1, NULL);
-- 
1.8.3.1



  parent reply	other threads:[~2014-06-03 11:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 11:02 [Cluster-devel] GFS2: Pre-pull patch posting (merge window) Steven Whitehouse
2014-06-03 11:02 ` [Cluster-devel] [PATCH 1/6] GFS2: quotas not being refreshed in gfs2_adjust_quota Steven Whitehouse
2014-06-03 11:02 ` Steven Whitehouse [this message]
2014-06-03 11:02 ` [Cluster-devel] [PATCH 3/6] GFS2: remove transaction glock Steven Whitehouse
2014-06-03 11:02 ` [Cluster-devel] [PATCH 4/6] GFS2: fs/gfs2/bmap.c: kernel-doc warning fixes Steven Whitehouse
2014-06-03 11:02 ` [Cluster-devel] [PATCH 5/6] GFS2: fs/gfs2/file.c: " Steven Whitehouse
2014-06-03 11:02 ` [Cluster-devel] [PATCH 6/6] GFS2: Prevent recovery before the local journal is set Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401793353-1469-3-git-send-email-swhiteho@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).