From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/6] GFS2: Hash the negative dentry during inode lookup
Date: Mon, 15 Sep 2014 10:32:46 +0100 [thread overview]
Message-ID: <1410773568-1573-5-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1410773568-1573-1-git-send-email-swhiteho@redhat.com>
From: Benjamin Coddington <bcodding@redhat.com>
Fix a regression introduced by:
6d4ade986f9c8df31e68 GFS2: Add atomic_open support
where an early return misses d_splice_alias() which had been
adding the negative dentry.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index e62e594..9317ddc 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -840,8 +840,10 @@ static struct dentry *__gfs2_lookup(struct inode *dir, struct dentry *dentry,
int error;
inode = gfs2_lookupi(dir, &dentry->d_name, 0);
- if (!inode)
+ if (inode == NULL) {
+ d_add(dentry, NULL);
return NULL;
+ }
if (IS_ERR(inode))
return ERR_CAST(inode);
--
1.8.3.1
next prev parent reply other threads:[~2014-09-15 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 9:32 [Cluster-devel] GFS2: Pre-pull patch posting (fixes) Steven Whitehouse
2014-09-15 9:32 ` [Cluster-devel] [PATCH 1/6] GFS2: fs/gfs2/super.c: replace seq_printf by seq_puts Steven Whitehouse
2014-09-15 9:32 ` [Cluster-devel] [PATCH 2/6] GFS2: Change maxlen variables to size_t Steven Whitehouse
2014-09-15 9:32 ` [Cluster-devel] [PATCH 3/6] GFS2: Request demote when a "try" flock fails Steven Whitehouse
2014-09-15 9:32 ` Steven Whitehouse [this message]
2014-09-15 9:32 ` [Cluster-devel] [PATCH 5/6] GFS2: Don't use MAXQUOTAS value Steven Whitehouse
2014-09-15 9:32 ` [Cluster-devel] [PATCH 6/6] GFS2: fix d_splice_alias() misuses Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410773568-1573-5-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).