From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/3] gfs2: Update timestamps on fallocate
Date: Wed, 12 Nov 2014 17:24:05 +0000 [thread overview]
Message-ID: <1415813045-6555-3-git-send-email-anprice@redhat.com> (raw)
In-Reply-To: <1415813045-6555-1-git-send-email-anprice@redhat.com>
gfs2_fallocate() wasn't updating ctime and mtime when modifying the
inode. Add a call to file_update_time() to do that.
Signed-off-by: Andrew Price <anprice@redhat.com>
---
fs/gfs2/file.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index b6d91bc..5b673cc 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -873,7 +873,8 @@ retry:
if (!(mode & FALLOC_FL_KEEP_SIZE) && (pos + count) > inode->i_size) {
i_size_write(inode, pos + count);
- mark_inode_dirty(inode);
+ /* Marks the inode as dirty */
+ file_update_time(file);
}
return generic_write_sync(file, pos, count);
--
1.9.3
next prev parent reply other threads:[~2014-11-12 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 17:24 [Cluster-devel] [PATCH 1/3] gfs2: Use inode_newsize_ok and get_write_access in fallocate Andrew Price
2014-11-12 17:24 ` [Cluster-devel] [PATCH 2/3] gfs2: Update i_size properly on fallocate Andrew Price
2014-11-12 17:24 ` Andrew Price [this message]
2014-11-17 12:03 ` [Cluster-devel] [PATCH 1/3] gfs2: Use inode_newsize_ok and get_write_access in fallocate Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415813045-6555-3-git-send-email-anprice@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).