From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/5] gfs2-utils tests: Document usage of convenience macros
Date: Wed, 14 Jan 2015 16:16:21 +0000 [thread overview]
Message-ID: <1421252181-20776-5-git-send-email-anprice@redhat.com> (raw)
In-Reply-To: <1421252181-20776-1-git-send-email-anprice@redhat.com>
Lower the barrier to writing tests by adding some docs to clarify the m4
convenience macros in testsuite.at.
Signed-off-by: Andrew Price <anprice@redhat.com>
---
tests/testsuite.at | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/testsuite.at b/tests/testsuite.at
index aa86966..0422b02 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -1,15 +1,18 @@
# Regenerate the sparse file used for testing and skip the test if it fails
+# Usage: GFS_TGT_REGEN
m4_define([GFS_TGT_REGEN],
[AT_CHECK([rm -f $GFS_TGT && truncate -s ${GFS_TGT_SZ}G ${GFS_TGT}], [ignore], [ignore], [ignore])
AT_SKIP_IF([test ! -f ${GFS_TGT}])])
# Regenerate, check, fsck is used a lot so combine it into one macro
+# Usage: GFS_FSCK_CHECK ([mkfs.gfs2 ... $GFS_TGT])
m4_define([GFS_FSCK_CHECK],
[GFS_TGT_REGEN
AT_CHECK($1, 0, [ignore], [ignore])
AT_CHECK([fsck.gfs2 -n $GFS_TGT], 0, [ignore], [ignore])])
# Regenerate, mkfs, modify fs with gfs2l, fsck
+# Usage: GFS_TGT_REGEN ([<mkfs.gfs2 command>], [<gfs2l script>])
m4_define([GFS_LANG_CHECK],
[GFS_TGT_REGEN
AT_CHECK($1, 0, [ignore], [ignore])
--
1.9.3
prev parent reply other threads:[~2015-01-14 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 16:16 [Cluster-devel] [PATCH 1/5] gfs2-utils tests: Add keywords to tests Andrew Price
2015-01-14 16:16 ` [Cluster-devel] [PATCH 2/5] gfs2-utils tests: Shorten TESTSUITEFLAGS to TOPTS Andrew Price
2015-01-14 16:16 ` [Cluster-devel] [PATCH 3/5] gfs2-utils tests: Improve docs Andrew Price
2015-01-14 16:16 ` [Cluster-devel] [PATCH 4/5] gfs2-utils tests: Skip unit tests if check is not found Andrew Price
2015-01-14 16:16 ` Andrew Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421252181-20776-5-git-send-email-anprice@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).