From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bas Peters Date: Wed, 11 Feb 2015 10:26:54 +0100 Subject: [Cluster-devel] [PATCH] fs: dlm: lockspace.c: removal of unnecessary check before calling kfree() Message-ID: <1423646814-22720-1-git-send-email-baspeters93@gmail.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit kfree() checks its argument. It is therefore unnecessary to do this twice. This issue was detected using Coccinelle. Signed-off-by: Bas Peters --- fs/dlm/lockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index f3e7278..b660b93 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -674,8 +674,7 @@ static int new_lockspace(const char *name, const char *cluster, out_lkbidr: idr_destroy(&ls->ls_lkbidr); for (i = 0; i < DLM_REMOVE_NAMES_MAX; i++) { - if (ls->ls_remove_names[i]) - kfree(ls->ls_remove_names[i]); + kfree(ls->ls_remove_names[i]); } out_rsbtbl: vfree(ls->ls_rsbtbl); -- 2.1.0