From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Marzinski Date: Wed, 15 Apr 2015 13:56:56 -0500 Subject: [Cluster-devel] [PATCH] GFS2: make sure S_NOSEC flag isn't overwritten Message-ID: <1429124216-20451-1-git-send-email-bmarzins@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit At the end of gfs2_set_inode_flags inode->i_flags is set to flags, so we should be mondifying flags instead of inode->i_flags, so it isn't overwritten. Signed-off-by: Benjamin Marzinski --- fs/gfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 6e600ab..80d1fd4 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -181,7 +181,7 @@ void gfs2_set_inode_flags(struct inode *inode) flags &= ~(S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC|S_NOSEC); if ((ip->i_eattr == 0) && !is_sxid(inode->i_mode)) - inode->i_flags |= S_NOSEC; + flags |= S_NOSEC; if (ip->i_diskflags & GFS2_DIF_IMMUTABLE) flags |= S_IMMUTABLE; if (ip->i_diskflags & GFS2_DIF_APPENDONLY) -- 2.1.0