cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Fabian Frederick <fabf@skynet.be>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH V2 linux-next] gfs2: fix shadow warning in gfs2_rbm_find()
Date: Mon, 18 May 2015 20:53:04 +0200	[thread overview]
Message-ID: <1431975184-1096-1-git-send-email-fabf@skynet.be> (raw)

bi was already declared and initialized globally in gfs2_rbm_find()

Suggested-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
V2: use global bi instead of new call to rbm_bi()
on local variable.

 fs/gfs2/rgrp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 900e515..cd53d6e 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1711,10 +1711,8 @@ static int gfs2_rbm_find(struct gfs2_rbm *rbm, u8 state, u32 *minext,
 		return ret;
 
 bitmap_full:	/* Mark bitmap as full and fall through */
-		if ((state == GFS2_BLKST_FREE) && initial_offset == 0) {
-			struct gfs2_bitmap *bi = rbm_bi(rbm);
+		if ((state == GFS2_BLKST_FREE) && initial_offset == 0)
 			set_bit(GBF_FULL, &bi->bi_flags);
-		}
 
 next_bitmap:	/* Find next bitmap in the rgrp */
 		rbm->offset = 0;
-- 
2.4.0



             reply	other threads:[~2015-05-18 18:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 18:53 Fabian Frederick [this message]
2015-05-18 20:37 ` [Cluster-devel] [PATCH V2 linux-next] gfs2: fix shadow warning in gfs2_rbm_find() Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431975184-1096-1-git-send-email-fabf@skynet.be \
    --to=fabf@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).