cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 09/16] gfs2: kerneldoc warning fixes
Date: Thu, 25 Jun 2015 12:42:32 -0500	[thread overview]
Message-ID: <1435254159-20788-10-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1435254159-20788-1-git-send-email-rpeterso@redhat.com>

From: Fabian Frederick <fabf@skynet.be>

Fixes the following kernel-doc warnings:
Warning(fs/gfs2/aops.c:180): No description found for parameter 'wbc'
Warning(fs/gfs2/aops.c:236): No description found for parameter 'end'
Warning(fs/gfs2/aops.c:236): No description found for parameter 'done_index'
Warning(fs/gfs2/aops.c:236): Excess function parameter 'writepage' description in 'gfs2_write_jdata_pagevec'
Warning(fs/gfs2/aops.c:346): Excess function parameter 'writepage' description in 'gfs2_write_cache_jdata'
Warning(fs/gfs2/aops.c:346): Excess function parameter 'data' description in 'gfs2_write_cache_jdata'
Warning(fs/gfs2/aops.c:605): No description found for parameter 'file'
Warning(fs/gfs2/aops.c:605): No description found for parameter 'mapping'
Warning(fs/gfs2/aops.c:605): No description found for parameter 'pages'
Warning(fs/gfs2/aops.c:605): No description found for parameter 'nr_pages'
Warning(fs/gfs2/aops.c:870): No description found for parameter 'copied'

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
 fs/gfs2/aops.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index a6e6990..7c5a96c 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -171,6 +171,7 @@ static int __gfs2_jdata_writepage(struct page *page, struct writeback_control *w
 /**
  * gfs2_jdata_writepage - Write complete page
  * @page: Page to write
+ * @wbc: The writeback control
  *
  * Returns: errno
  *
@@ -221,9 +222,10 @@ static int gfs2_writepages(struct address_space *mapping,
  * gfs2_write_jdata_pagevec - Write back a pagevec's worth of pages
  * @mapping: The mapping
  * @wbc: The writeback control
- * @writepage: The writepage function to call for each page
  * @pvec: The vector of pages
  * @nr_pages: The number of pages to write
+ * @end: End position
+ * @done_index: Page index
  *
  * Returns: non-zero if loop should terminate, zero otherwise
  */
@@ -333,8 +335,6 @@ continue_unlock:
  * gfs2_write_cache_jdata - Like write_cache_pages but different
  * @mapping: The mapping to write
  * @wbc: The writeback control
- * @writepage: The writepage function to call
- * @data: The data to pass to writepage
  *
  * The reason that we use our own function here is that we need to
  * start transactions before we grab page locks. This allows us
@@ -588,6 +588,10 @@ int gfs2_internal_read(struct gfs2_inode *ip, char *buf, loff_t *pos,
 
 /**
  * gfs2_readpages - Read a bunch of pages at once
+ * @file: The file to read from
+ * @mapping: Address space info
+ * @pages: List of pages to read
+ * @nr_pages: Number of pages to read
  *
  * Some notes:
  * 1. This is only for readahead, so we can simply ignore any things
@@ -853,7 +857,7 @@ static int gfs2_stuffed_write_end(struct inode *inode, struct buffer_head *dibh,
  * @mapping: The address space to write to
  * @pos: The file position
  * @len: The length of the data
- * @copied:
+ * @copied: How much was actually copied by the VFS
  * @page: The page that has been written
  * @fsdata: The fsdata (unused in GFS2)
  *
-- 
2.1.0



  parent reply	other threads:[~2015-06-25 17:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 17:42 [Cluster-devel] [PATCH 00/16] GFS2: Pre-pull patch posting (merge window) Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 01/16] GFS2: Use average srttb value in congestion calculations Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 02/16] GFS2: Average in only non-zero round-trip times for congestion stats Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 03/16] GFS2: mark the journal idle to fix ro mounts Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 04/16] GFS2: inode.c: indent with TABs, not spaces Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 05/16] gfs2: handle NULL rgd in set_rgrp_preferences Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 06/16] GFS2: add support for rename2 and RENAME_EXCHANGE Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 07/16] GFS2: make sure S_NOSEC flag isn't overwritten Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 08/16] gfs2: convert simple_str to kstr Bob Peterson
2015-06-25 17:42 ` Bob Peterson [this message]
2015-06-25 17:42 ` [Cluster-devel] [PATCH 10/16] gfs2: fix shadow warning in gfs2_rbm_find() Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 11/16] gfs2: fix quota updates on block boundaries Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 12/16] gfs2: limit quota log messages Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 13/16] gfs2: s64 cast for negative quota value Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 14/16] gfs2: Don't support fallocate on jdata files Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 15/16] GFS2: Don't add all glocks to the lru Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 16/16] GFS2: Don't brelse rgrp buffer_heads every allocation Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435254159-20788-10-git-send-email-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).