cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 13/16] gfs2: s64 cast for negative quota value
Date: Thu, 25 Jun 2015 12:42:36 -0500	[thread overview]
Message-ID: <1435254159-20788-14-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1435254159-20788-1-git-send-email-rpeterso@redhat.com>

From: Abhi Das <adas@redhat.com>

One-line fix to cast quota value to s64 before comparison.
By default the quantity is treated as u64.

Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
---
 fs/gfs2/quota.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index dcd598a..c2607a2 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -798,7 +798,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc,
 	loc -= sizeof(q); /* gfs2_internal_read would've advanced the loc ptr */
 	err = -EIO;
 	be64_add_cpu(&q.qu_value, change);
-	if (be64_to_cpu(q.qu_value) < 0)
+	if (((s64)be64_to_cpu(q.qu_value)) < 0)
 		q.qu_value = 0; /* Never go negative on quota usage */
 	qd->qd_qb.qb_value = q.qu_value;
 	if (fdq) {
-- 
2.1.0



  parent reply	other threads:[~2015-06-25 17:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 17:42 [Cluster-devel] [PATCH 00/16] GFS2: Pre-pull patch posting (merge window) Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 01/16] GFS2: Use average srttb value in congestion calculations Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 02/16] GFS2: Average in only non-zero round-trip times for congestion stats Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 03/16] GFS2: mark the journal idle to fix ro mounts Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 04/16] GFS2: inode.c: indent with TABs, not spaces Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 05/16] gfs2: handle NULL rgd in set_rgrp_preferences Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 06/16] GFS2: add support for rename2 and RENAME_EXCHANGE Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 07/16] GFS2: make sure S_NOSEC flag isn't overwritten Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 08/16] gfs2: convert simple_str to kstr Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 09/16] gfs2: kerneldoc warning fixes Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 10/16] gfs2: fix shadow warning in gfs2_rbm_find() Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 11/16] gfs2: fix quota updates on block boundaries Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 12/16] gfs2: limit quota log messages Bob Peterson
2015-06-25 17:42 ` Bob Peterson [this message]
2015-06-25 17:42 ` [Cluster-devel] [PATCH 14/16] gfs2: Don't support fallocate on jdata files Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 15/16] GFS2: Don't add all glocks to the lru Bob Peterson
2015-06-25 17:42 ` [Cluster-devel] [PATCH 16/16] GFS2: Don't brelse rgrp buffer_heads every allocation Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435254159-20788-14-git-send-email-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).