* [Cluster-devel] [GFS2 PATCH] GFS2: Protect freeing directory hash table with i_lock spin_lock
[not found] <1463852047.67688766.1446131499539.JavaMail.zimbra@redhat.com>
@ 2015-10-29 15:12 ` Bob Peterson
0 siblings, 0 replies; only message in thread
From: Bob Peterson @ 2015-10-29 15:12 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This patch changes function gfs2_dir_hash_inval so that it uses
the i_lock spin_lock to protect the in-core hash table, i_hash_cache.
This will prevent double-frees due to a race between gfs2_clear_inode
and inode invalidation.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 487527b..ad8a5b7 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -388,8 +388,13 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip)
*/
void gfs2_dir_hash_inval(struct gfs2_inode *ip)
{
- __be64 *hc = ip->i_hash_cache;
+ __be64 *hc;
+
+ spin_lock(&ip->i_inode.i_lock);
+ hc = ip->i_hash_cache;
ip->i_hash_cache = NULL;
+ spin_unlock(&ip->i_inode.i_lock);
+
kvfree(hc);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-29 15:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1463852047.67688766.1446131499539.JavaMail.zimbra@redhat.com>
2015-10-29 15:12 ` [Cluster-devel] [GFS2 PATCH] GFS2: Protect freeing directory hash table with i_lock spin_lock Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).