From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH 12/15] gfs2: Remove unused param non_block from gfs2_inode_lookup
Date: Mon, 5 Oct 2015 10:36:34 -0500 [thread overview]
Message-ID: <1444059397-4705-13-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1444059397-4705-1-git-send-email-rpeterso@redhat.com>
Function gfs2_inode_lookup had parameter non_block which is no
longer used. This patch removes it and fixes the comments and
callers.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
fs/gfs2/dir.c | 2 +-
fs/gfs2/inode.c | 8 ++++----
fs/gfs2/inode.h | 3 +--
fs/gfs2/ops_fstype.c | 2 +-
4 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 487527b..f4caf2f 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -1563,7 +1563,7 @@ struct inode *gfs2_dir_search(struct inode *dir, const struct qstr *name,
brelse(bh);
if (fail_on_exist)
return ERR_PTR(-EEXIST);
- return gfs2_inode_lookup(dir->i_sb, dtype, addr, formal_ino, 0);
+ return gfs2_inode_lookup(dir->i_sb, dtype, addr, formal_ino);
}
return ERR_PTR(-ENOENT);
}
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 1c57f7d..631d4ef 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -78,15 +78,15 @@ static void gfs2_set_iop(struct inode *inode)
/**
* gfs2_inode_lookup - Lookup an inode
* @sb: The super block
- * @no_addr: The inode number
* @type: The type of the inode
- * non_block: Can we block on inodes that are being freed?
+ * @no_addr: The inode number
+ * @no_formal_ino: The formal inode number (for NFS)
*
* Returns: A VFS inode, or an error
*/
struct inode *gfs2_inode_lookup(struct super_block *sb, unsigned int type,
- u64 no_addr, u64 no_formal_ino, int non_block)
+ u64 no_addr, u64 no_formal_ino)
{
struct inode *inode;
struct gfs2_inode *ip;
@@ -304,7 +304,7 @@ struct inode *gfs2_lookup_by_inum(struct gfs2_sbd *sdp, u64 no_addr,
if (error)
goto fail;
- inode = gfs2_inode_lookup(sb, DT_UNKNOWN, no_addr, 0, 1);
+ inode = gfs2_inode_lookup(sb, DT_UNKNOWN, no_addr, 0);
if (IS_ERR(inode))
goto fail;
diff --git a/fs/gfs2/inode.h b/fs/gfs2/inode.h
index 031e301..9e838b3 100644
--- a/fs/gfs2/inode.h
+++ b/fs/gfs2/inode.h
@@ -94,8 +94,7 @@ err:
}
extern struct inode *gfs2_inode_lookup(struct super_block *sb, unsigned type,
- u64 no_addr, u64 no_formal_ino,
- int non_block);
+ u64 no_addr, u64 no_formal_ino);
extern struct inode *gfs2_inode_lookup_for_del(struct super_block *sb,
u64 no_addr);
extern struct inode *gfs2_lookup_by_inum(struct gfs2_sbd *sdp, u64 no_addr,
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index baab99b..ee44116 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -451,7 +451,7 @@ static int gfs2_lookup_root(struct super_block *sb, struct dentry **dptr,
struct dentry *dentry;
struct inode *inode;
- inode = gfs2_inode_lookup(sb, DT_DIR, no_addr, 0, 0);
+ inode = gfs2_inode_lookup(sb, DT_DIR, no_addr, 0);
if (IS_ERR(inode)) {
fs_err(sdp, "can't read in %s inode: %ld\n", name, PTR_ERR(inode));
return PTR_ERR(inode);
--
2.4.3
next prev parent reply other threads:[~2015-10-05 15:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 15:36 [Cluster-devel] [GFS2 PATCH 00/15] Fifteen patches related to file unlink->delete->new Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 01/15] GFS2: Update master statfs buffer with sd_statfs_spin locked Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 02/15] GFS2: Allow fail_gunlock3 to set the free_vfs_inode bit Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 03/15] GFS2: Protect log tail calculations with inside locks Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 04/15] GFS2: Wait for iopen glock dequeues Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 05/15] GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 06/15] GFS2: Prevent gl_delete work for re-used inodes Bob Peterson
2015-10-06 18:40 ` Andrew W Elble
2015-10-06 19:02 ` Bob Peterson
2015-10-06 19:33 ` Andrew W Elble
2015-10-12 19:15 ` Andrew W Elble
2015-10-13 17:28 ` Andrew W Elble
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 07/15] GFS2: Truncate address space mapping when deleting an inode Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 08/15] GFS2: Don't filter out I_FREEING inodes anymore Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 09/15] GFS2: generalize gfs2_check_blk_type Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 10/15] GFS2: Change from tr_touched to tr_bufs Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 11/15] GFS2: Add new function gfs2_inode_lookup_for_del Bob Peterson
2015-10-05 15:36 ` Bob Peterson [this message]
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 13/15] gfs2: Use new variable i_gl instead of ip->i_gl Bob Peterson
2015-10-06 18:31 ` Andrew W Elble
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 14/15] GFS2: Hold onto iopen glock longer when dinode creation fails Bob Peterson
2015-10-05 15:36 ` [Cluster-devel] [GFS2 PATCH 15/15] GFS2: Rework gfs2_evict_inode to prevent collisions with openers Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444059397-4705-13-git-send-email-rpeterso@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).