From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH v2 00/15] Fifteen patches related to file unlink->delete->new
Date: Tue, 6 Oct 2015 14:02:33 -0500 [thread overview]
Message-ID: <1444158168-23036-1-git-send-email-rpeterso@redhat.com> (raw)
On September 10, I posted a set of 11 preliminary patches for GFS2 that
revised the way GFS2 transitions files from unlinked to deleted. I received
no feedback. Since that time, I've found several bugs in testing and fixed
them. I've also split the last patch into five pieces. This is the revised
set of fifteen patches.
This set of fifteen patches was designed to fix several problems in GFS2
that had to do with transitioning dinodes from unlinked to deleted and
back to created again. Many of these problems resulted in dinodes being
not transitioning from the "unlinked" state to a "deleted" state.
Some of them address the problem of dinodes being re-created in place
(due to limited space in the file system) in which case callbacks were
received and delete work was queued for dinodes that were already
deleted and re-used by another node, only to have the callback destroy
the newly created dinode.
These patches were tested using virts that had 4GB GFS2 file systems,
using a test case that recreated numerous problems. With these patches,
all those problems disappear.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
Bob Peterson (15):
GFS2: Update master statfs buffer with sd_statfs_spin locked
GFS2: Allow fail_gunlock3 to set the free_vfs_inode bit
GFS2: Protect log tail calculations with inside locks
GFS2: Wait for iopen glock dequeues
GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear
GFS2: Prevent gl_delete work for re-used inodes
GFS2: Truncate address space mapping when deleting an inode
GFS2: Don't filter out I_FREEING inodes anymore
GFS2: generalize gfs2_check_blk_type
GFS2: Change from tr_touched to tr_bufs
GFS2: Add new function gfs2_inode_lookup_for_del
gfs2: Remove unused param non_block from gfs2_inode_lookup
gfs2: Use new variable i_gl instead of ip->i_gl
GFS2: Hold onto iopen glock longer when dinode creation fails
GFS2: Rework gfs2_evict_inode to prevent collisions with openers
fs/gfs2/dir.c | 2 +-
fs/gfs2/export.c | 2 +-
fs/gfs2/glock.c | 15 ++--
fs/gfs2/glops.c | 3 +-
fs/gfs2/incore.h | 7 +-
fs/gfs2/inode.c | 246 ++++++++++++++++++++++++++++++++++++---------------
fs/gfs2/inode.h | 7 +-
fs/gfs2/log.c | 7 +-
fs/gfs2/main.c | 2 +
fs/gfs2/meta_io.c | 12 ++-
fs/gfs2/ops_fstype.c | 2 +-
fs/gfs2/rgrp.c | 52 ++++++++---
fs/gfs2/rgrp.h | 1 +
fs/gfs2/super.c | 66 ++++++++++----
fs/gfs2/trans.c | 13 +--
15 files changed, 307 insertions(+), 130 deletions(-)
--
2.4.3
next reply other threads:[~2015-10-06 19:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 19:02 Bob Peterson [this message]
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 01/15] GFS2: Update master statfs buffer with sd_statfs_spin locked Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 02/15] GFS2: Allow fail_gunlock3 to set the free_vfs_inode bit Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 03/15] GFS2: Protect log tail calculations with inside locks Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 04/15] GFS2: Wait for iopen glock dequeues Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 05/15] GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 06/15] GFS2: Prevent gl_delete work for re-used inodes Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 07/15] GFS2: Truncate address space mapping when deleting an inode Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 08/15] GFS2: Don't filter out I_FREEING inodes anymore Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 09/15] GFS2: generalize gfs2_check_blk_type Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 10/15] GFS2: Change from tr_touched to tr_bufs Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 11/15] GFS2: Add new function gfs2_inode_lookup_for_del Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 12/15] gfs2: Remove unused param non_block from gfs2_inode_lookup Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 13/15] gfs2: Use new variable i_gl instead of ip->i_gl Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 14/15] GFS2: Hold onto iopen glock longer when dinode creation fails Bob Peterson
2015-10-16 13:26 ` Andrew W Elble
2015-10-16 13:33 ` Bob Peterson
2015-10-16 13:49 ` Andrew W Elble
2015-10-16 14:02 ` Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 15/15] GFS2: Rework gfs2_evict_inode to prevent collisions with openers Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444158168-23036-1-git-send-email-rpeterso@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).