cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH v2 07/15] GFS2: Truncate address space mapping when deleting an inode
Date: Tue,  6 Oct 2015 14:02:40 -0500	[thread overview]
Message-ID: <1444158168-23036-8-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1444158168-23036-1-git-send-email-rpeterso@redhat.com>

In function gfs2_delete_inode() we write and flush the mapping for
a glock, among other things. We truncate the mapping for the inode,
but we never truncate the mapping for the glock. This patch makes it
also truncate the metamapping. This avoid cases where the glock is
reused by another process who is trying to recreate an inode in its
place using the same block.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
 fs/gfs2/super.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 555fea0..06bd72b 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -1511,6 +1511,7 @@ static void gfs2_evict_inode(struct inode *inode)
 	struct gfs2_sbd *sdp = sb->s_fs_info;
 	struct gfs2_inode *ip = GFS2_I(inode);
 	struct gfs2_holder gh;
+	struct address_space *metamapping;
 	int error;
 
 	if (test_bit(GIF_FREE_VFS_INODE, &ip->i_flags)) {
@@ -1575,8 +1576,8 @@ static void gfs2_evict_inode(struct inode *inode)
 
 out_truncate:
 	gfs2_log_flush(sdp, ip->i_gl, NORMAL_FLUSH);
+	metamapping = gfs2_glock2aspace(ip->i_gl);
 	if (test_bit(GLF_DIRTY, &ip->i_gl->gl_flags)) {
-		struct address_space *metamapping = gfs2_glock2aspace(ip->i_gl);
 		filemap_fdatawrite(metamapping);
 		filemap_fdatawait(metamapping);
 	}
@@ -1589,6 +1590,7 @@ out_truncate:
 		goto out_unlock;
 	/* Needs to be done before glock release & also in a transaction */
 	truncate_inode_pages(&inode->i_data, 0);
+	truncate_inode_pages(metamapping, 0);
 	gfs2_trans_end(sdp);
 
 out_unlock:
-- 
2.4.3



  parent reply	other threads:[~2015-10-06 19:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 19:02 [Cluster-devel] [GFS2 PATCH v2 00/15] Fifteen patches related to file unlink->delete->new Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 01/15] GFS2: Update master statfs buffer with sd_statfs_spin locked Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 02/15] GFS2: Allow fail_gunlock3 to set the free_vfs_inode bit Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 03/15] GFS2: Protect log tail calculations with inside locks Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 04/15] GFS2: Wait for iopen glock dequeues Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 05/15] GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 06/15] GFS2: Prevent gl_delete work for re-used inodes Bob Peterson
2015-10-06 19:02 ` Bob Peterson [this message]
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 08/15] GFS2: Don't filter out I_FREEING inodes anymore Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 09/15] GFS2: generalize gfs2_check_blk_type Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 10/15] GFS2: Change from tr_touched to tr_bufs Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 11/15] GFS2: Add new function gfs2_inode_lookup_for_del Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 12/15] gfs2: Remove unused param non_block from gfs2_inode_lookup Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 13/15] gfs2: Use new variable i_gl instead of ip->i_gl Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 14/15] GFS2: Hold onto iopen glock longer when dinode creation fails Bob Peterson
2015-10-16 13:26   ` Andrew W Elble
2015-10-16 13:33     ` Bob Peterson
2015-10-16 13:49       ` Andrew W Elble
2015-10-16 14:02         ` Bob Peterson
2015-10-06 19:02 ` [Cluster-devel] [GFS2 PATCH v2 15/15] GFS2: Rework gfs2_evict_inode to prevent collisions with openers Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444158168-23036-8-git-send-email-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).