[Cluster-devel] [PATCH v2] mkfs.gfs2: print message about BKLDISCARD ioctl taking a long time

[Cluster-devel] [PATCH v2] mkfs.gfs2: print message about BKLDISCARD ioctl taking a long time

[Paul Evans]

When running mkfs.gfs2 the BLKDISCARD ioctl() can sit waiting for a
long time without feedback.

Added a message in mkfs.gfs2 to the user just before the ioctl begins
to warn the user that the operation could take a while to complete.

Signed-off-by: Paul Evans <pevans@redhat.com>
---
 gfs2/mkfs/main_mkfs.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c
index d3d8edf..97e1a06 100644
--- a/gfs2/mkfs/main_mkfs.c
+++ b/gfs2/mkfs/main_mkfs.c
@@ -904,9 +904,17 @@ int main(int argc, char *argv[])
 	if (opts.confirm && !opts.override)
 		are_you_sure();
 
-	if (!S_ISREG(opts.dev.stat.st_mode) && opts.discard)
+	if (!S_ISREG(opts.dev.stat.st_mode) && opts.discard) {
+		if (!opts.quiet) {
+			printf("%s", _("Discarding device contents (may take a while on large devices): "));
+			fflush(stdout);
+		}
 		discard_blocks(opts.dev.fd, opts.dev.size, opts.debug);
 
+		if (!opts.quiet)
+			printf("%s", _("Done\n"));
+	}
+
 	error = place_rgrps(&sbd, rgs, &opts);
 	if (error) {
 		fprintf(stderr, _("Failed to build resource groups\n"));
-- 
1.9.3