From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 22 Oct 2015 14:30:08 -0500 Subject: [Cluster-devel] [GFS2 PATCH v3 00/14] Fourteen patches related to file unlink->delete->new Message-ID: <1445542222-30672-1-git-send-email-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On September 10, I posted a set of 11 preliminary patches for GFS2 that revised the way GFS2 transitions files from unlinked to deleted. I received no feedback. Since that time, I've found several bugs in testing and fixed them. I've also split the last patch into five pieces. This is the revised set of fourteen patches. On October 6, I posted a revised (v2) set of 15 patches, but as Andrew Elble found out, they weren't quite right. There was still a glock referencing problem. Based on that problem, I eliminated the patch (previously called "gfs2: Use new variable i_gl instead of ip->i_gl") and revised the last one ("GFS2: Rework gfs2_evict_inode to prevent collisions with openers"). This version seems to work better and doesn't leave millions of glocks behind. This set of fourteen patches was designed to fix several problems in GFS2 that had to do with transitioning dinodes from unlinked to deleted and back to created again. Many of these problems resulted in dinodes being not transitioning from the "unlinked" state to a "deleted" state. Some of them address the problem of dinodes being re-created in place (due to limited space in the file system) in which case callbacks were received and delete work was queued for dinodes that were already deleted and re-used by another node, only to have the callback destroy the newly created dinode. These patches were tested using virts that had 4GB GFS2 file systems, using a test case that recreated numerous problems. With these patches, all those problems disappear. Signed-off-by: Bob Peterson --- Bob Peterson (14): GFS2: Update master statfs buffer with sd_statfs_spin locked GFS2: Allow fail_gunlock3 to set the free_vfs_inode bit GFS2: Protect log tail calculations with inside locks GFS2: Wait for iopen glock dequeues GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear GFS2: Prevent gl_delete work for re-used inodes GFS2: Truncate address space mapping when deleting an inode GFS2: Don't filter out I_FREEING inodes anymore GFS2: generalize gfs2_check_blk_type GFS2: Change from tr_touched to tr_bufs GFS2: Add new function gfs2_inode_lookup_for_del gfs2: Remove unused param non_block from gfs2_inode_lookup GFS2: Hold onto iopen glock longer when dinode creation fails GFS2: Rework gfs2_evict_inode to prevent collisions with openers fs/gfs2/dir.c | 2 +- fs/gfs2/export.c | 2 +- fs/gfs2/glock.c | 17 ++-- fs/gfs2/glops.c | 3 +- fs/gfs2/incore.h | 7 +- fs/gfs2/inode.c | 246 ++++++++++++++++++++++++++++++++++++--------------- fs/gfs2/inode.h | 7 +- fs/gfs2/log.c | 7 +- fs/gfs2/main.c | 2 + fs/gfs2/meta_io.c | 12 ++- fs/gfs2/ops_fstype.c | 2 +- fs/gfs2/rgrp.c | 52 ++++++++--- fs/gfs2/rgrp.h | 1 + fs/gfs2/super.c | 52 ++++++++--- fs/gfs2/trans.c | 13 +-- 15 files changed, 300 insertions(+), 125 deletions(-) -- 2.4.3