From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 5 Nov 2015 11:26:48 -0600 Subject: [Cluster-devel] [PATCH 5/5] GFS2: Protect freeing directory hash table with i_lock spin_lock In-Reply-To: <1446744408-21047-1-git-send-email-rpeterso@redhat.com> References: <1446744408-21047-1-git-send-email-rpeterso@redhat.com> Message-ID: <1446744408-21047-6-git-send-email-rpeterso@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This patch changes function gfs2_dir_hash_inval so it uses the i_lock spin_lock to protect the in-core hash table, i_hash_cache. This will prevent double-frees due to a race between gfs2_evict_inode and inode invalidation. Signed-off-by: Bob Peterson --- fs/gfs2/dir.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 487527b..ad8a5b7 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -388,8 +388,13 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip) */ void gfs2_dir_hash_inval(struct gfs2_inode *ip) { - __be64 *hc = ip->i_hash_cache; + __be64 *hc; + + spin_lock(&ip->i_inode.i_lock); + hc = ip->i_hash_cache; ip->i_hash_cache = NULL; + spin_unlock(&ip->i_inode.i_lock); + kvfree(hc); } -- 2.4.3