cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 6/6] GFS2: Fix rgrp end rounding problem for bsize < page size
Date: Mon,  9 Nov 2015 10:01:32 -0600	[thread overview]
Message-ID: <1447084892-30129-7-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1447084892-30129-1-git-send-email-rpeterso@redhat.com>

This patch fixes a bug introduced by commit 7005c3e. That patch
tries to map a vm range for resource groups, but the calculation
breaks down when the block size is less than the page size.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
 fs/gfs2/rgrp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index d29dd0c..c134c04 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -933,8 +933,9 @@ static int read_rindex_entry(struct gfs2_inode *ip)
 		goto fail;
 
 	rgd->rd_gl->gl_object = rgd;
-	rgd->rd_gl->gl_vm.start = rgd->rd_addr * bsize;
-	rgd->rd_gl->gl_vm.end = rgd->rd_gl->gl_vm.start + (rgd->rd_length * bsize) - 1;
+	rgd->rd_gl->gl_vm.start = (rgd->rd_addr * bsize) & PAGE_CACHE_MASK;
+	rgd->rd_gl->gl_vm.end = PAGE_CACHE_ALIGN((rgd->rd_addr +
+						  rgd->rd_length) * bsize) - 1;
 	rgd->rd_rgl = (struct gfs2_rgrp_lvb *)rgd->rd_gl->gl_lksb.sb_lvbptr;
 	rgd->rd_flags &= ~(GFS2_RDF_UPTODATE | GFS2_RDF_PREFERRED);
 	if (rgd->rd_data > sdp->sd_max_rg_data)
-- 
2.4.3



      parent reply	other threads:[~2015-11-09 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 16:01 [Cluster-devel] [PATCH v2 0/6] Pre-pull patch posting (merge window) Bob Peterson
2015-11-09 16:01 ` [Cluster-devel] [PATCH v2 1/6] GFS2: fallocate: do not rely on file_update_time to mark the inode dirty Bob Peterson
2015-11-09 16:01 ` [Cluster-devel] [PATCH v2 2/6] GFS2: Set s_mode before parsing mount options Bob Peterson
2015-11-09 16:01 ` [Cluster-devel] [PATCH v2 3/6] gfs2: Add missing else in trans_add_meta/data Bob Peterson
2015-11-09 16:01 ` [Cluster-devel] [PATCH v2 4/6] gfs2: Remove gl_spin define Bob Peterson
2015-11-09 16:01 ` [Cluster-devel] [PATCH v2 5/6] GFS2: Protect freeing directory hash table with i_lock spin_lock Bob Peterson
2015-11-09 16:01 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447084892-30129-7-git-send-email-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).