cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 15/19] GFS2: Truncate address space mapping when deleting an inode
Date: Tue, 12 Jan 2016 12:55:05 -0500	[thread overview]
Message-ID: <1452621309-25857-16-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1452621309-25857-1-git-send-email-rpeterso@redhat.com>

In function gfs2_delete_inode() we write and flush the mapping for
a glock, among other things. We truncate the mapping for the inode,
but we never truncate the mapping for the glock. This patch makes it
also truncate the metamapping. This avoid cases where the glock is
reused by another process who is trying to recreate an inode in its
place using the same block.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
---
 fs/gfs2/super.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 4f0708f..8f960a5 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -1519,6 +1519,7 @@ static void gfs2_evict_inode(struct inode *inode)
 	struct gfs2_sbd *sdp = sb->s_fs_info;
 	struct gfs2_inode *ip = GFS2_I(inode);
 	struct gfs2_holder gh;
+	struct address_space *metamapping;
 	int error;
 
 	if (test_bit(GIF_FREE_VFS_INODE, &ip->i_flags)) {
@@ -1583,8 +1584,8 @@ static void gfs2_evict_inode(struct inode *inode)
 
 out_truncate:
 	gfs2_log_flush(sdp, ip->i_gl, NORMAL_FLUSH);
+	metamapping = gfs2_glock2aspace(ip->i_gl);
 	if (test_bit(GLF_DIRTY, &ip->i_gl->gl_flags)) {
-		struct address_space *metamapping = gfs2_glock2aspace(ip->i_gl);
 		filemap_fdatawrite(metamapping);
 		filemap_fdatawait(metamapping);
 	}
@@ -1597,6 +1598,7 @@ out_truncate:
 		goto out_unlock;
 	/* Needs to be done before glock release & also in a transaction */
 	truncate_inode_pages(&inode->i_data, 0);
+	truncate_inode_pages(metamapping, 0);
 	gfs2_trans_end(sdp);
 
 out_unlock:
-- 
2.5.0



  parent reply	other threads:[~2016-01-12 17:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 17:54 [Cluster-devel] [PATCH 00/19] Pre-pull patch posting (merge window) Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 01/19] gfs2: Automatically set GFS2_DIF_SYSTEM flag on system files Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 02/19] GFS2: Delete an unnecessary check before the function call "iput" Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 03/19] GFS2: Use rht_for_each_entry_rcu in glock_hash_walk Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 04/19] gfs2: Extended attribute readahead Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 05/19] gfs2: Extended attribute readahead optimization Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 06/19] GFS2: Extract quota data from reservations structure (revert 5407e24) Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 07/19] GFS2: Make rgrp reservations part of the gfs2_inode structure Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 08/19] GFS2: Reduce size of incore inode Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 09/19] GFS2: Update master statfs buffer with sd_statfs_spin locked Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 10/19] GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 11/19] gfs2: keep offset when splitting dir leaf blocks Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 12/19] gfs2: change gfs2 readdir cookie Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 13/19] gfs2: clear journal live bit in gfs2_log_flush Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 14/19] GFS2: Wait for iopen glock dequeues Bob Peterson
2016-01-12 17:55 ` Bob Peterson [this message]
2016-01-12 17:55 ` [Cluster-devel] [PATCH 16/19] GFS2: Release iopen glock in gfs2_create_inode error cases Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 17/19] GFS2: Always use iopen glock for gl_deletes Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 18/19] GFS2: Don't do glock put on when inode creation fails Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 19/19] gfs2: fix flock panic issue Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452621309-25857-16-git-send-email-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).