From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 01/19] gfs2: Automatically set GFS2_DIF_SYSTEM flag on system files
Date: Tue, 12 Jan 2016 12:54:51 -0500 [thread overview]
Message-ID: <1452621309-25857-2-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1452621309-25857-1-git-send-email-rpeterso@redhat.com>
From: Abhi Das <adas@redhat.com>
When new files and directories are created inside a parent directory
we automatically inherit the GFS2_DIF_SYSTEM flag (if set) and assign
it to the new file/dirs.
All new system files/dirs created in the metafs by, say gfs2_jadd,
will have this flag set because they will have parent directories in
the metafs whose GFS2_DIF_SYSTEM flag has already been set (most likely
by a previous mkfs.gfs2)
Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
fs/gfs2/file.c | 4 ++--
fs/gfs2/inode.c | 5 +++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 5e42546..2012820 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -298,9 +298,9 @@ static int gfs2_set_flags(struct file *filp, u32 __user *ptr)
gfsflags &= ~GFS2_DIF_TOPDIR;
if (gfsflags & GFS2_DIF_INHERIT_JDATA)
gfsflags ^= (GFS2_DIF_JDATA | GFS2_DIF_INHERIT_JDATA);
- return do_gfs2_set_flags(filp, gfsflags, ~0);
+ return do_gfs2_set_flags(filp, gfsflags, ~GFS2_DIF_SYSTEM);
}
- return do_gfs2_set_flags(filp, gfsflags, ~GFS2_DIF_JDATA);
+ return do_gfs2_set_flags(filp, gfsflags, ~(GFS2_DIF_SYSTEM | GFS2_DIF_JDATA));
}
static long gfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 063fdfc..2c05bc3 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -685,6 +685,11 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
ip->i_entries = 2;
break;
}
+
+ /* Force SYSTEM flag on all files and subdirs of a SYSTEM directory */
+ if (dip->i_diskflags & GFS2_DIF_SYSTEM)
+ ip->i_diskflags |= GFS2_DIF_SYSTEM;
+
gfs2_set_inode_flags(inode);
if ((GFS2_I(d_inode(sdp->sd_root_dir)) == dip) ||
--
2.5.0
next prev parent reply other threads:[~2016-01-12 17:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 17:54 [Cluster-devel] [PATCH 00/19] Pre-pull patch posting (merge window) Bob Peterson
2016-01-12 17:54 ` Bob Peterson [this message]
2016-01-12 17:54 ` [Cluster-devel] [PATCH 02/19] GFS2: Delete an unnecessary check before the function call "iput" Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 03/19] GFS2: Use rht_for_each_entry_rcu in glock_hash_walk Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 04/19] gfs2: Extended attribute readahead Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 05/19] gfs2: Extended attribute readahead optimization Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 06/19] GFS2: Extract quota data from reservations structure (revert 5407e24) Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 07/19] GFS2: Make rgrp reservations part of the gfs2_inode structure Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 08/19] GFS2: Reduce size of incore inode Bob Peterson
2016-01-12 17:54 ` [Cluster-devel] [PATCH 09/19] GFS2: Update master statfs buffer with sd_statfs_spin locked Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 10/19] GFS2: Reintroduce a timeout in function gfs2_gl_hash_clear Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 11/19] gfs2: keep offset when splitting dir leaf blocks Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 12/19] gfs2: change gfs2 readdir cookie Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 13/19] gfs2: clear journal live bit in gfs2_log_flush Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 14/19] GFS2: Wait for iopen glock dequeues Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 15/19] GFS2: Truncate address space mapping when deleting an inode Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 16/19] GFS2: Release iopen glock in gfs2_create_inode error cases Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 17/19] GFS2: Always use iopen glock for gl_deletes Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 18/19] GFS2: Don't do glock put on when inode creation fails Bob Peterson
2016-01-12 17:55 ` [Cluster-devel] [PATCH 19/19] gfs2: fix flock panic issue Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452621309-25857-2-git-send-email-rpeterso@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).