From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [[GFS2 PATCH] 3/3] gfs2: Large-filesystem fix for 32-bit systems
Date: Wed, 15 Jun 2016 09:46:52 -0500 [thread overview]
Message-ID: <1466002012-12115-4-git-send-email-rpeterso@redhat.com> (raw)
In-Reply-To: <1466002012-12115-1-git-send-email-rpeterso@redhat.com>
From: Andreas Gruenbacher <agruenba@redhat.com>
Commit ff34245d switched from iget5_locked to iget_locked among other
things, but iget_locked doesn't work for filesystems larger than 2^32
blocks on 32-bit systems. Switch back to iget5_locked. Filesystems
larger than 2^32 blocks are unrealistic to work well on 32-bit systems,
so this is mostly a code cleanliness fix.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
fs/gfs2/inode.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index ebff26e..481b649 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -37,19 +37,34 @@
#include "super.h"
#include "glops.h"
+static int iget_test(struct inode *inode, void *opaque)
+{
+ u64 no_addr = *(u64 *)opaque;
+
+ return GFS2_I(inode)->i_no_addr == no_addr;
+}
+
+static int iget_set(struct inode *inode, void *opaque)
+{
+ u64 no_addr = *(u64 *)opaque;
+
+ GFS2_I(inode)->i_no_addr = no_addr;
+ inode->i_ino = no_addr;
+ return 0;
+}
+
static struct inode *gfs2_iget(struct super_block *sb, u64 no_addr)
{
struct inode *inode;
repeat:
- inode = iget_locked(sb, no_addr);
+ inode = iget5_locked(sb, no_addr, iget_test, iget_set, &no_addr);
if (!inode)
return inode;
if (is_bad_inode(inode)) {
iput(inode);
goto repeat;
}
- GFS2_I(inode)->i_no_addr = no_addr;
return inode;
}
--
2.5.5
next prev parent reply other threads:[~2016-06-15 14:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 14:46 [Cluster-devel] [[GFS2 PATCH] 0/3] Patches for gfs2_lookup_by_inum deadlock Bob Peterson
2016-06-15 14:46 ` [Cluster-devel] [[GFS2 PATCH] 1/3] gfs2: Fix gfs2_lookup_by_inum lock inversion Bob Peterson
2016-06-15 14:46 ` [Cluster-devel] [[GFS2 PATCH] 2/3] gfs2: Get rid of gfs2_ilookup Bob Peterson
2016-06-16 15:51 ` Steven Whitehouse
2016-06-15 14:46 ` Bob Peterson [this message]
2016-06-16 15:48 ` [Cluster-devel] [[GFS2 PATCH] 3/3] gfs2: Large-filesystem fix for 32-bit systems Steven Whitehouse
2016-06-17 9:40 ` [Cluster-devel] [PATCH] gfs2: Initialize iopen glock holder for new inodes Andreas Gruenbacher
2016-06-17 13:41 ` Bob Peterson
2016-06-27 15:20 ` [Cluster-devel] [[GFS2 PATCH] 0/3] Patches for gfs2_lookup_by_inum deadlock Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466002012-12115-4-git-send-email-rpeterso@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).