From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Date: Tue, 09 May 2017 11:33:03 -0400 Subject: [Cluster-devel] [RFC xfstests PATCH] xfstests: add a writeback error handling test In-Reply-To: <20170424150019.GA3288@infradead.org> References: <20170424134551.10301-1-jlayton@redhat.com> <20170424150019.GA3288@infradead.org> Message-ID: <1494343983.2659.7.camel@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, 2017-04-24 at 08:00 -0700, Christoph Hellwig wrote: > On Mon, Apr 24, 2017 at 09:45:51AM -0400, Jeff Layton wrote: > > With the patch series above, ext4 now passes. xfs and btrfs end up in > > r/o mode after the test. xfs returns -EIO at that point though, and > > btrfs returns -EROFS. What behavior we actually want there, I'm not > > certain. We might be able to mitigate that by putting the journals on a > > separate device? > > This looks like XFS shut down because of a permanent write error from > dm-error. Which seems like the expected behavior. Oops, didn't see this message earlier... Yeah, that's entirely reasonable when there is a write error to the journal. The latest version of this uses $SCRATCH_LOGDEV to put the journal on a different device, and with that I get the expected behavior from xfs. Thanks, -- Jeff Layton