cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fs: GFS2: constify attribute_group structures.
Date: Fri, 30 Jun 2017 09:42:23 -0400 (EDT)	[thread overview]
Message-ID: <1521062963.27753093.1498830143169.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <ac2cb3ad9f0aa5bfc972469ad5a20ba16da9f9cd.1498800255.git.arvind.yadav.cs@gmail.com>

----- Original Message -----
| attribute_groups are not supposed to change at runtime. All functions
| working with attribute_groups provided by <linux/sysfs.h> work with const
| attribute_group. So mark the non-const structs as const.
| 
| File size before:
|    text	   data	    bss	    dec	    hex	filename
|    5259	   1344	      8	   6611	   19d3	fs/gfs2/sys.o
| 
| File size After adding 'const':
|    text	   data	    bss	    dec	    hex	filename
|    5371	   1216	      8	   6595	   19c3	fs/gfs2/sys.o
| 
| Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Hi,

Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:

1fc2e87 GFS2: constify attribute_group structures.

Regards,

Bob Peterson
Red Hat File Systems



      reply	other threads:[~2017-06-30 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-30  5:28 [Cluster-devel] [PATCH] fs: GFS2: constify attribute_group structures Arvind Yadav
2017-06-30 13:42 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521062963.27753093.1498830143169.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).