* [Cluster-devel] [GFS2 PATCH] GFS2: Remove unnecessary memory barrier
[not found] <54448320.19773408.1374760351761.JavaMail.root@redhat.com>
@ 2013-07-25 13:53 ` Bob Peterson
2013-09-04 15:27 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2013-07-25 13:53 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Function test_and_clear_bit implies a memory barrier, so subsequent
memory barriers are unnecessary.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 9435384..a45b1e0 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1411,7 +1411,6 @@ __acquires(&lru_lock)
if (demote_ok(gl))
handle_callback(gl, LM_ST_UNLOCKED, 0, false);
WARN_ON(!test_and_clear_bit(GLF_LOCK, &gl->gl_flags));
- smp_mb__after_clear_bit();
if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0)
gfs2_glock_put_nolock(gl);
spin_unlock(&gl->gl_spin);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 PATCH] GFS2: Remove unnecessary memory barrier
2013-07-25 13:53 ` [Cluster-devel] [GFS2 PATCH] GFS2: Remove unnecessary memory barrier Bob Peterson
@ 2013-09-04 15:27 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2013-09-04 15:27 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
On Thu, 2013-07-25 at 09:53 -0400, Bob Peterson wrote:
> Hi,
>
> Function test_and_clear_bit implies a memory barrier, so subsequent
> memory barriers are unnecessary.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
Now in the -nmw tree. Thanks,
Steve.
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 9435384..a45b1e0 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -1411,7 +1411,6 @@ __acquires(&lru_lock)
> if (demote_ok(gl))
> handle_callback(gl, LM_ST_UNLOCKED, 0, false);
> WARN_ON(!test_and_clear_bit(GLF_LOCK, &gl->gl_flags));
> - smp_mb__after_clear_bit();
> if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0)
> gfs2_glock_put_nolock(gl);
> spin_unlock(&gl->gl_spin);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-04 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <54448320.19773408.1374760351761.JavaMail.root@redhat.com>
2013-07-25 13:53 ` [Cluster-devel] [GFS2 PATCH] GFS2: Remove unnecessary memory barrier Bob Peterson
2013-09-04 15:27 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).